JvanKatwijk
commented
3 years ago That is a good one! I'll have it fixed.
Btw, I was modifying some code in the library (and some of the example programs), since I was somewhat unhappy with passing individual functions through the who;e computing chain. Change will be a (major) the dabInit and other functions take as parameter a struct API_struct with as fields the various callback functions, b (minor) I added a callback function that can be used to print the TII data (major, minor)
On the todo list is a rewrite of example 5 (the one with keyboard "up" and "down" through the list), where a simple message queui is used to handle the result of the callbacks.
Op wo 21 apr. 2021 om 22:04 schreef srcejon @.***>:
Hi,
It looks like there is stack corruption in reedSolomon::decode_rs().
It has:
uint8_t omega [nroots];
Then calls computeOmega()
Which does:
omega [nroots] = codeLength;
omega [nroots] is beyond the end of the allocated array (which of course only goes to nroots-1).
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/dab-cmdline/issues/73, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCPHQDGKMQFQ75ZYGQNMCTTJ4VUTANCNFSM43LBMVFQ .
-- Jan van Katwijk
srcejon
Hi,
It looks like there is stack corruption in reedSolomon::decode_rs().
It has:
uint8_t omega [nroots];
Then calls computeOmega()
Which does:
omega [nroots] = codeLength;
omega [nroots] is beyond the end of the allocated array (which of course only goes to nroots-1).