search

JvanKatwijk / dab-cmdline

DAB decoding library with example of its use
GNU General Public License v2.0
57 stars 29 forks source link

Added possibility to save Dynamic Labels and slides to file #85

Closed vale-max closed 2 years ago

vale-max commented 2 years ago

Hello @JvanKatwijk I added to example 3 the possibility to save the MOT slides and the dynamic label to file as I'm using your tools to add DAB radio to https://github.com/rern/rAudio-1 and it would be nice to have the label and the image displayed in the GUI.

It works but probably is poorly written as I'm not confident with cpp so I took pieces here and there and reassembled them in a seemingly functional way.

Creating this pull request in case you think it can be useful to others and is not too ugly. Many many thanks for your work, Valerio

JvanKatwijk commented 2 years ago

Looks fine to me

Op di 21 jun. 2022 om 16:40 schreef vale-max @.***>:

Hello @JvanKatwijk https://github.com/JvanKatwijk I added to example 3 the possibility to save the MOT slides and the dynamic label to file as I'm using your tools to add DAB radio to https://github.com/rern/rAudio-1 and it would be nice to have the label and the image displayed in the GUI.

It works but probably is poorly written as I'm not confident with cpp so I took pieces here and there and reassembled them in a seemingly functional way.

Creating this pull request in case you think it can be useful to others and is not too ugly. Many many thanks for your work, Valerio

You can view, comment on, or merge this pull request online at:

https://github.com/JvanKatwijk/dab-cmdline/pull/85 Commit Summary

File Changes

(1 file https://github.com/JvanKatwijk/dab-cmdline/pull/85/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/dab-cmdline/pull/85, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCPHQGULVQI326CLUD7GUTVQHH7BANCNFSM5ZMTJGDQ . You are receiving this because you were mentioned.Message ID: @.***>

-- Jan van Katwijk

JvanKatwijk commented 2 years ago

Thanks for the contibutions

JvanKatwijk commented 2 years ago

Just one comment. The dynamic label texts are sent more than one. For Qt-DAB I added - some time ago - the possibility to save these texts and to avoid needless repetition I added a "short term memory" module that contained the N dynamic label lines and is used to provent adding the line to the output if it in "in". You could have a look at "dl-cache.h" in includes/support directory of qt-dab. Pretty straightforward implementation

Op di 21 jun. 2022 om 19:19 schreef jan van katwijk @.***

:

Looks fine to me

Op di 21 jun. 2022 om 16:40 schreef vale-max @.***>:

Hello @JvanKatwijk https://github.com/JvanKatwijk I added to example 3 the possibility to save the MOT slides and the dynamic label to file as I'm using your tools to add DAB radio to https://github.com/rern/rAudio-1 and it would be nice to have the label and the image displayed in the GUI.

It works but probably is poorly written as I'm not confident with cpp so I took pieces here and there and reassembled them in a seemingly functional way.

Creating this pull request in case you think it can be useful to others and is not too ugly. Many many thanks for your work, Valerio

You can view, comment on, or merge this pull request online at:

https://github.com/JvanKatwijk/dab-cmdline/pull/85 Commit Summary

File Changes

(1 file https://github.com/JvanKatwijk/dab-cmdline/pull/85/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/dab-cmdline/pull/85, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCPHQGULVQI326CLUD7GUTVQHH7BANCNFSM5ZMTJGDQ . You are receiving this because you were mentioned.Message ID: @.***>

-- Jan van Katwijk

-- Jan van Katwijk

vale-max commented 2 years ago

Hi Jvan, thanks for the suggestion, I've checked the dl-cache but I think I do not really need it for my purpose. I need to display only the last label sent, and the GUI is not "woke up" by the update to the file, just pulls it every 5 seconds, so I do not append the labels to the label file, just rewrite it with latest one.