JvanKatwijk / dab-cmdline

DAB decoding library with example of its use
GNU General Public License v2.0
57 stars 29 forks source link

tii_data_t doesn't include userData parameter #89

Closed srcejon closed 1 year ago

srcejon commented 1 year ago

Most of the callbacks in API_struct include the userData parameter. However, tii_data_t doesn't, which is problematic if trying to receive from multiple transmitters.

Would it be possible to change to:

typedef void (*tii_data_t)(int, void *);

Thanks.

JvanKatwijk commented 1 year ago

I am not sure I understand the problem. Adding a parameter to the tii_data_Handler function is trivial, but the caller - in this case the function "show_tii" in the dab-processor class - does not use an additional parameter

Op di 7 feb. 2023 om 17:38 schreef srcejon @.***>:

Most of the callbacks in API_struct include the userData parameter. However, tii_data_t doesn't, which is problematic if trying to receive from multiple transmitters.

— Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/dab-cmdline/issues/89, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCPHQDZG7IOFPRAZMJCRQDWWJ273ANCNFSM6AAAAAAUUGD6C4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Jan van Katwijk

srcejon commented 1 year ago

The additional parameter would be userData that is passed to dabInit, the same that is passed to all of the other callbacks.

So the call would be changed to:

show_tii (res, userData);
JvanKatwijk commented 1 year ago

done, I did not look (yet?) to the python example though

Op di 7 feb. 2023 om 21:20 schreef srcejon @.***>:

The additional parameter would be userData that is passed to dabInit, the same that is passed to all of the other callbacks.

So the call would be changed to:

show_tii (res, userData);

— Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/dab-cmdline/issues/89#issuecomment-1421391198, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCPHQBKRIBSNEI4FU4CUGDWWKVCRANCNFSM6AAAAAAUUGD6C4 . You are receiving this because you commented.Message ID: @.***>

-- Jan van Katwijk

srcejon commented 1 year ago

Thanks.

Just to clarify it's usage, we are plotting the location of the transmitter on a map. So when decoding multiple DAB streams, the user data is used to indicate which stream a TII is for.