JvanKatwijk / qt-dab

Qt-DAB, a general software DAB (DAB+) decoder with a (slight) focus on showing the signal
http://www.sdr-j.tk
GNU General Public License v2.0
299 stars 62 forks source link

SLS are mixed up with SPI pictures #300

Closed andimik closed 11 months ago

andimik commented 1 year ago

There is a bug in handling backend. It will show a picture from backend (SPI, EPG service) at the actual service.

If you cannot see the three screenshots, please open it on github.

grafik

In the screenshot you see private station Radio 1, but the "SLS" is not their slideshow, but the backend picture from public service PRVI, see following log:

we have now 2 backends running
going to write file /tmp/Qt-DAB-files/357
going to write file /tmp/Qt-DAB-files/e4_9201_32x32_0.png
going to write file /tmp/Qt-DAB-files/e4_9202_32x32_0.png
going to write file /tmp/Qt-DAB-files/e4_9201_112x32_1.png
going to write file /tmp/Qt-DAB-files/e4_9202_112x32_1.png

grafik

This will happen when the SLS of the service has not displayed yet AND a picture from backend has been decoded.

After some seconds the correct SLS will be shown:

grafik

JvanKatwijk commented 1 year ago

If I understand it correctly, then a slide, decoded in the EPG service is being displayed (and later overruled as soon the current servide sends its picture?

Op vr 22 sep 2023 om 18:51 schreef andimik @.***>:

There is a bug in handling backend. It will show a picture from backend (SPI, EPG service) at the actual service.

If you cannot see the three screenshots, please open it on github.

[image: grafik] https://user-images.githubusercontent.com/24510556/270001997-42117538-5f77-4202-981d-759dbf98736d.png

In the screenshot you see private station Radio 1, but the "SLS" is not their slideshow, but the backend picture from public service PRVI, see following log:

we have now 2 backends running going to write file /tmp/Qt-DAB-files/357 going to write file /tmp/Qt-DAB-files/e4_9201_32x32_0.png going to write file /tmp/Qt-DAB-files/e4_9202_32x32_0.png going to write file /tmp/Qt-DAB-files/e4_9201_112x32_1.png going to write file /tmp/Qt-DAB-files/e4_9202_112x32_1.png

[image: grafik] https://user-images.githubusercontent.com/24510556/270002640-0e582dec-23a8-49f6-b174-7253d7696cfa.png

This will happen when the SLS of the service has not displayed yet AND a picture from backend has been decoded.

After some seconds the correct SLS will be shown:

[image: grafik] https://user-images.githubusercontent.com/24510556/270002801-2ac173a2-b037-4726-899b-f2643b2bd30a.png

— Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/qt-dab/issues/300, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCPHQFANWCL5HA5QOC22HDX3W6ZXANCNFSM6AAAAAA5DL5VSE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Jan van Katwijk

andimik commented 1 year ago

yes, EPG pictures are shown in a radio program.

JvanKatwijk commented 1 year ago

It can be solved in a pretty transparent way. It will require minor mods to the backend handling and will therefore impact versions 4, 5, and 6. I probably need the weekend to handle it

Op vr 22 sep 2023 om 19:27 schreef andimik @.***>:

yes, EPG pictures are shown in a radio program.

— Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/qt-dab/issues/300#issuecomment-1731786088, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCPHQC4GGHXPFY2CX76KP3X3XDANANCNFSM6AAAAAA5DL5VSE . You are receiving this because you commented.Message ID: @.***>

-- Jan van Katwijk

JvanKatwijk commented 1 year ago

should be fixed now in the sources in github, for v4, v5 and v6

Op vr 22 sep 2023 om 20:49 schreef jan van katwijk @.***>:

It can be solved in a pretty transparent way. It will require minor mods to the backend handling and will therefore impact versions 4, 5, and 6. I probably need the weekend to handle it

Op vr 22 sep 2023 om 19:27 schreef andimik @.***>:

yes, EPG pictures are shown in a radio program.

— Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/qt-dab/issues/300#issuecomment-1731786088, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCPHQC4GGHXPFY2CX76KP3X3XDANANCNFSM6AAAAAA5DL5VSE . You are receiving this because you commented.Message ID: @.***>

-- Jan van Katwijk

-- Jan van Katwijk

andimik commented 1 year ago

Good, the EPG pictures are now NOT showing anymore in the audio service.

But there is still a bug. Qt-DAB won't show the own SLS as it does not update this information. It seems that it crashed internally when received garbage (but this is not related to reception, I just opened the frame dump recording window).

In the attached aac file you see DL+ and SLS

Radio-1-80-a-----Sa--Sept--23-13-11-32-2023.zip Bildschirmfoto vom 2023-09-23 13-19-55 Bildschirmfoto vom 2023-09-23 13-15-19

But Qt-DAB did never show it. Please also see "NG BY MYSELF" which was part of the garbage frame. See other (still not solved issue) https://github.com/JvanKatwijk/qt-dab/issues/280

Bildschirmfoto vom 2023-09-23 13-14-21