JvanKatwijk / qt-dab

Qt-DAB, a general software DAB (DAB+) decoder with a (slight) focus on showing the signal
http://www.sdr-j.tk
GNU General Public License v2.0
299 stars 62 forks source link

Wrong filename and path for png #331

Closed andimik closed 1 month ago

andimik commented 1 month ago

Dear Jan,

there is a typo in the file name for:

https://github.com/JvanKatwijk/qt-dab/blob/master/qt-dab-6.5/qt-dab-6.5-256x265.png It should be 256.

I wonder why you are using a wrong filename (6.5 <-> 6) in

https://github.com/JvanKatwijk/qt-dab/blob/17a3797a8b5c7a2551c4718057c1c72dd4792358/qt-dab-6.5/qt-dab-6.5-build.txt#L10

Seems you are already referring it here:

https://github.com/JvanKatwijk/qt-dab/blob/17a3797a8b5c7a2551c4718057c1c72dd4792358/qt-dab-6.5/resources.qrc#L25

https://github.com/JvanKatwijk/qt-dab/blob/17a3797a8b5c7a2551c4718057c1c72dd4792358/qt-dab-6.5/resources.qrc#L24

find | grep 256
./res/qt-dab-5-256x256.png
./res/qt-dab-4-256x256.png
./res/qt-dab-6-256x256.png
./qt-dab-RC/qt-dab-RC-256x256.png
./qt-dab-6.5/qt-dab-6.5-256x265.png
find | grep 128
./res/qt-dab-6-128x128.png
JvanKatwijk commented 1 month ago

wow, you have a sharp eye. Fixed in the sources

Op di 1 okt 2024 om 16:07 schreef andimik @.***>:

Dear Jan,

there is a typo in the file name for:

https://github.com/JvanKatwijk/qt-dab/blob/master/qt-dab-6.5/qt-dab-6.5-256x265.png It should be 256.

I wonder why you are using a wrong filename (6.5 <-> 6) in

https://github.com/JvanKatwijk/qt-dab/blob/17a3797a8b5c7a2551c4718057c1c72dd4792358/qt-dab-6.5/qt-dab-6.5-build.txt#L10

Seems you are already referring it here:

https://github.com/JvanKatwijk/qt-dab/blob/17a3797a8b5c7a2551c4718057c1c72dd4792358/qt-dab-6.5/resources.qrc#L25

https://github.com/JvanKatwijk/qt-dab/blob/17a3797a8b5c7a2551c4718057c1c72dd4792358/qt-dab-6.5/resources.qrc#L24

find | grep 256 ./res/qt-dab-5-256x256.png ./res/qt-dab-4-256x256.png ./res/qt-dab-6-256x256.png ./qt-dab-RC/qt-dab-RC-256x256.png ./qt-dab-6.5/qt-dab-6.5-256x265.png

find | grep 128 ./res/qt-dab-6-128x128.png

— Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/qt-dab/issues/331, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCPHQEN37OQFFUHSIXNY63ZZKUDVAVCNFSM6AAAAABPFVNS76VHI2DSMVQWIX3LMV43ASLTON2WKOZSGU2TSMZWGU2TOMI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Jan van Katwijk