Jvinniec / CppEphem

CppEphem is a self-contained ephemeris package written in C++. It allows computation of celestial coordinate and date conversions and planet ephemerides by leveraging the Standards of Fundamental Astronomy (SOFA) software (included in the repo). It is C++11 compatible.
2 stars 2 forks source link

CECoordinates conversion routines too confusing #20

Closed Jvinniec closed 5 years ago

Jvinniec commented 5 years ago

Simply put, there are too many ways to do coordinate conversions in CECoordinates. These should be simplified to reduce the confusion on exactly how a user should transform between coordinates. The methods should be rewritten to have the following properties:

If there are no objections, I will implement these changes for v1.3.

Jvinniec commented 5 years ago

This change can also be extended to CECoordinates::AngularSeparation methods (there are 3). Doing so would resolve the confusion when comparing observed coordinates and also reduce the number of methods from 3 to 2.

Jvinniec commented 5 years ago

Resolved via PR #28