Closed Jvinniec closed 5 years ago
This change can also be extended to CECoordinates::AngularSeparation
methods (there are 3). Doing so would resolve the confusion when comparing observed coordinates and also reduce the number of methods from 3 to 2.
Resolved via PR #28
Simply put, there are too many ways to do coordinate conversions in CECoordinates. These should be simplified to reduce the confusion on exactly how a user should transform between coordinates. The methods should be rewritten to have the following properties:
CECoordinates
,CEDate
,CEObserver
classes to do to the transformations. This means dropping all the methods that allow passing/returning angles as doubles. It will also facilitate the next point.ConvertTo
,ConvertToObserved
,GetObservedCoords
(short form),GetObservedCoords
(long form), and 6 additional methods accounting for a short/long form for each of theXXXToObserved
methods. I would propose:ConvertTo
,ConvertToObserved
, and a singleXXXToObserved
method. This drops the number of methods from 10 to 5.If there are no objections, I will implement these changes for v1.3.