Jvinniec / CppEphem

CppEphem is a self-contained ephemeris package written in C++. It allows computation of celestial coordinate and date conversions and planet ephemerides by leveraging the Standards of Fundamental Astronomy (SOFA) software (included in the repo). It is C++11 compatible.
2 stars 2 forks source link

Implement new class: CESkyCoord #28

Closed Jvinniec closed 5 years ago

Jvinniec commented 5 years ago

This pull request resolves issue #20 by defining a new class CESkyCoord that does the coordinate conversions. It has been designed to be more streamlined than CECoordinates, providing more intuitive inputs/outputs and reducing the overall number of methods to a more manageable amount. Additionally, CECoordinates had a lot of duplicate functionality with several other methods that have been removed with CESkyCoord. A copy constructor for CESkyCoord from a CECoordinates object has been added to make the changeover smoother for users.

All methods and executables that once used CECoordinates now depend on CESkyCoord. While CECoordinates still functions as it always has (and additional tests have been added to ensure it functions correctly), it is considered deprecated and will be removed in a future release. No additional functionality will be added to CECoordinates!

Additional tests have also been added and some of the executables have been slightly rewritten to be more streamlined using CESkyCoord and CEAngle objects.