Jweng88 / pe

0 stars 0 forks source link

Names with an extra whitespace is considered a new student to be added into the list #3

Open Jweng88 opened 11 months ago

Jweng88 commented 11 months ago

Steps:

  1. When adding a student using add n/John Tan e/e2222222@u.nus.edu t/good, the student can be successfully added into the list as a new student as shown in the screenshot below.

image.png

However, in the real world, it is unlikely that an extra whitespace between the names would make it a different person, perhaps can add a warning to check if they are the same person?

soc-se-bot commented 11 months ago

Team's Response

The naming convention is not what sets students apart as students may share the same name, it is their email address (or NUSNET ID) that will be the unique identifier. The given example has two different email addresses, which means they would be different students regardless of 'similarity' of names

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Firstly, it was not clear that the email address was the only main unique identifier.

Secondly, it is possible for nus students to set up additional email address under their names from the NUS Identity website, so allow adding a student with additional whitespace but different email address may be incorrect as there is a possibility of being the same student but different email address.

Thirdly, a user may accidentally type the address wrongly while typing his/her name with additional whitespace, which can result in adding the same student unknowingly.

Therefore, with regards to duplicate detection, rather than only relying on email address, a warning in such near miss case for names can be given for the user to make the final decision to prevent potential duplicate cases to go undetected.