search

Jweng88 / pe

0 stars 0 forks source link

Edit command allows editing a person's name to the same name #6

Open Jweng88 opened 11 months ago

Jweng88 commented 11 months ago

Steps:

  1. When editing a student name with Alex Yeoh to the same name Alex Yeoh, it shows a successful edited message when there is no change to the name of the student as shown in the screenshot below.

image.png

nus-se-script commented 11 months ago

Team's Response

Given that the user typed out a valid command, the current success message is valid. However, we could have been more specific in saying that no change was made, but this does not affect any functionality of our application, and thus is more of a 'good to have'

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]

## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [x] I disagree **Reason for disagreement:** Since it is a bug related to duplicate detection, it should be part of feature flaw instead.
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]