Jwensloff / brew-buddy

https://brew-buddy.vercel.app
0 stars 2 forks source link

Feature/error handling 2 jb #40

Closed JoshBennett793 closed 1 year ago

JoshBennett793 commented 1 year ago

What I did:

Did this break anything?

Type of change

Checklist:

What's next?

JoshBennett793 commented 1 year ago

I think implementing the useReducer messed with the search functionality

I've pulled and merged with main locally with no breaks to the search functionality.

I've also opened the PR up in a GH codespace and it is working as expected. I believe your local main may be different from remote main.

JoshBennett793 commented 1 year ago

I think implementing the useReducer messed with the search functionality

I've pulled and merged with main locally with no breaks to the search functionality.

  • I merged Renee's changes to FavoriteContext.js and pushed those in to this PR. Reference: 82d4ddf

I've also opened the PR up in a GH codespace and it is working as expected. I believe your local main may be different from remote main.

The bug originated from the BreweryContext component in which I was attempting to use the array of params as the switch expression, causing unexpected behavior. This bug has been resolved. Reference: 25b7aaf

banjaminh commented 1 year ago

All issues fixed! Nice work!