Jwensloff / brew-buddy

https://brew-buddy.vercel.app

0 stars 2 forks source link

Test/url routing user flow && Feature/pretty error page #73

Closed JoshBennett793 closed 1 year ago

JoshBennett793 commented 1 year ago

Test/url routing user flow

What I did:

Tested user flow for url routing
Added test for invalid city to homepage.spec
Change url route to reflect if only state param is searched for

Did this break anything?

[x] No
[ ] Yes

Type of change

[x] New feature (non-breaking change which adds functionality)
[ ] Styling
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Refactor(DRY-ing up/ reorganizing code, etc.)
[ ] Super small fix (Corrected a typo, removed a comment, etc.)
[x] Tests

Checklist:

[x] If this code needs to be tested, all tests are passing
[x] The code runs locally
[ ] There are comments where clarification/ organization is needed
[x] The code is DRY. If it's not, I tried my best
[x] I reviewed my code before pushing

Feature/pretty error page

What I did:

Added custom error message to api call
Styled and positioned elements on error page
Responsive layout across multiple screen sizes
Conditionally rendered a specific error page based on whether error page resulted from network request error or manually navigation
Stretched the header background image to account for ultra wide screens.

Did this break anything?

[x] No
[ ] Yes

Type of change

[x] New feature (non-breaking change which adds functionality)
[x] Styling
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Refactor(DRY-ing up/ reorganizing code, etc.)
[ ] Super small fix (Corrected a typo, removed a comment, etc.)

Checklist:

[x] If this code needs to be tested, all tests are passing
[x] The code runs locally
[ ] There are comments where clarification/ organization is needed
[x] The code is DRY. If it's not, I tried my best
[x] I reviewed my code before pushing

JoshBennett793 commented 1 year ago

Closes #55