Jxleejiaxin / pe

0 stars 0 forks source link

Long student ID results in weird UI #6

Open Jxleejiaxin opened 1 year ago

Jxleejiaxin commented 1 year ago

image.png

As you can see, inputting an exceptionally long student ID will result in some weird display. Unfortunately, as a tutor, I am now unable to view tommy oriley's student ID.

nus-se-bot commented 1 year ago

Team's Response

Thank you for the feedback!

Please refer to #4507 for more details.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

adding a student with a long id will overflow the UI

image.png

Although this is only a UI bug, I decided to put it in low severity as it has resulted in me being unable to see the ids of the other students. This could cause inconvenience to users, but it does not happen often. This makes the product less useful to TAs.


[original: nus-cs2103-AY2223S2/pe-interim#4413] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for the feedback!

Note that tester has stated that they are "unable to see the ids of the other students", but in the rare cases of unusually long student ids from user error and students having different lengths of student id in a class, there are still methods to view the full student id.

Comparing to the cases mentioned in the course website which is most relevant to this issue shown below image.png, this issue matches more to the first case of extreme user behaviour, as it is unusual or impractical for student ids to be that long, or for a class of students to have varying lengths of student id to cause the ids to be skewed to the right. But our application is still able to handle these cases.

This extreme user case has not defeated CLIpboard as it is still usable and good to go, as they can still edit the student ids to the intended one. Hence the issue is rejected.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** I do not think it is an "extreme user behavior" for a student ID to be >23 characters long to cause this error in my screenshot. If the user shrank the UI, I believe this error would occur at an even lower character limit. However, I do agree that the user can manually select the student to view their ID, so this might just be a cosmetic issue. (veryLow severity)