search

Jxyme / simple-discord-rpc

Beautify your Discord profile with a fully customizable Discord Rich Presence, now with buttons.
32 stars 5 forks source link

Optional Buttons #11

Closed Matteoki closed 2 years ago

Matteoki commented 2 years ago

Hi there, best plugin for rich presence i've tested.

But im pretty sure the buttons are optional too, if i try to delete the json value or key the plugin refuses to work, just a little minor thing.

Jxyme commented 2 years ago

Hi, @Matteoki. Thank you for the feedback, I'm glad you like it!

I've just pushed an update to resolve this. Initially they weren't made to be optional.. however hopefully with these changes all should be well and good.

Keep the configuration layout exactly as it is in the config.json.example. If you'd like to disable one or both buttons, simply set the values to null. Below I've included an example that'll enable the primary button, but disable the secondary button.

"buttons": {
  "primary": {
    "label": "Portfolio",
    "url": "https://jayme.dev/"
  },
  "secondary": {
    "label": null,
    "url": null
  }
}

Please let me know if you run into any issues with these changes.

Matteoki commented 2 years ago

Incredible to say the least!

One more thing i found out is that the program shuts down whenever:

I say this because i would like to keep the rpc on the second desktop (so that it doesn't bother me) and never touch it again (Instead of starting it again everytime it closes)

Wonderful job Jxyme!

Jxyme commented 2 years ago

Incredible to say the least!

One more thing i found out is that the program shuts down whenever:

  • Discord Crashes
  • BetterDiscord Crashes
  • There's no internet connection

I say this because i would like to keep the rpc on the second desktop (so that it doesn't bother me) and never touch it again (Instead of starting it again everytime it closes)

Wonderful job Jxyme!

I've just pushed an update to automatically attempt to reconnect if/when Discord closes.

Please let me know if you run into any issues with these changes.

Matteoki commented 2 years ago

All good!