Jyckle / sncrs

SmashNight Competitive Ranking System
GNU General Public License v3.0
1 stars 0 forks source link

Update handling of VOD queries to accept more arguments #13

Closed coltatgh closed 1 year ago

coltatgh commented 1 year ago

Complements SmashNightBot issue for updating !vods command to accept additional arguments: https://github.com/coltatgh/SmashNightBot/issues/7

Filters would be needed to select VODs

Jyckle commented 1 year ago

@coltatgh Hey, what do you think is the desired method of specifying a given smashnight? Potential options:

Jyckle commented 1 year ago

Had another thought, might leave it querying based on Smashnight I'd in the API, and work on a separate Smashnight API, so we can prompt the user with which Smashnight they want, and then use the id from that in this query!

I.e.

User: !vods by_sn player1 player2
Which Smashnight would you like vods from?
1) Smashnight Season 5 Night 1 on 2023-02-01
2) Smashnight Season 4 Night 10 on 2022-10-01
Enter the number: <User inputs 2>
Your vods from Smashnight Season 4 Night 10 on 2022-10-01 are:
- list of videos between player 1 and player 2
coltatgh commented 1 year ago

Copying our IM discussion here for future reference: I think specifying the SmashNight in the format #.# (e.g. 5.2) should be sufficient

Jyckle commented 1 year ago

Closed with PR #17