I really wasn't quite sure how to best share this idea, and originally thought of just commenting it all, but wanted to test it out to make sure it works before suggesting it, and then figured I shouldn't make you retype all of this if you don't have to. So settled on making a PR to your branch! I figure this way you can review, see if you agree, and then if you do, you can just merge it into your branch and your original PR will be updated!
Here's why I think these changes will be helpful:
This way, our specific icons aren't tied to the source code (don't have to do a PR next time we want to update the team icons, we can just go to the admin panel and do it!)
The logic for displaying them gets simpler/doesn't require source code changes if we add or remove a team
The one downside (which I think is fine) is that we have to go to the admin panel the first time and upload the images for each team there, but I think that is a worthwhile trade!
The admin interface looks like this after the change:
Let me know what you think, and thanks for bringing us out of season 3!! :)
I really wasn't quite sure how to best share this idea, and originally thought of just commenting it all, but wanted to test it out to make sure it works before suggesting it, and then figured I shouldn't make you retype all of this if you don't have to. So settled on making a PR to your branch! I figure this way you can review, see if you agree, and then if you do, you can just merge it into your branch and your original PR will be updated!
Here's why I think these changes will be helpful: This way, our specific icons aren't tied to the source code (don't have to do a PR next time we want to update the team icons, we can just go to the admin panel and do it!) The logic for displaying them gets simpler/doesn't require source code changes if we add or remove a team
The one downside (which I think is fine) is that we have to go to the admin panel the first time and upload the images for each team there, but I think that is a worthwhile trade!
The admin interface looks like this after the change:
Let me know what you think, and thanks for bringing us out of season 3!! :)