[BUG] Manual leveling issues "G420 Sn" instead of "M420 Sn"

Jyers / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. | Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.

http://marlinfw.org

GNU General Public License v3.0

2.14k stars 387 forks source link

[BUG] Manual leveling issues "G420 Sn" instead of "M420 Sn" #200

Closed Schnabulation closed 3 years ago

Schnabulation commented 3 years ago

Description

In order to make the manuel leveling independent from the leveling mesh the board issues a command to disable the mesh. The correct command for this is M420 S0 - however the printer recieves a G420 S0. This is not a known command.

After the leveling is complete the board restores the mesh. The correct command is M420 S1 - however the printer recieves a G420 S1.

Here is a screenshot from the commandline of OctoPrint - see the last two lines:

Manual_Leveling

dafi87 commented 3 years ago

I noticed the same thing. Problem is https://github.com/Jyers/Marlin/blob/9c82eab3510bc60af153c068bc9ae5028c4c18f7/Marlin/src/lcd/extui/lib/creality_dwin/creality_dwin.cpp#L775 and https://github.com/Jyers/Marlin/blob/9c82eab3510bc60af153c068bc9ae5028c4c18f7/Marlin/src/lcd/extui/lib/creality_dwin/creality_dwin.cpp#L936

Jyers commented 3 years ago

Classic case of me programming way too late at night... Fixed with latest commit