search

Jyers / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. | Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
http://marlinfw.org
GNU General Public License v3.0
2.14k stars 386 forks source link

Stuck in a Loop after Stopping a print #2023

Closed Ergonomicmike closed 2 years ago

Ergonomicmike commented 2 years ago

Description

LCh-77/Marlin/tree/bugfix-2.1.x_JYERSUI-Enhanced

BLTUBL-LA/Ender3V2_422BLT_UBL_LA.bin

When you Stop a print, you cannot return to the Print Menu. (In fact, IIRC, even when the print is finished, I am stuck in a loop and have to power down the printer.)

Steps to Reproduce

  1. Start a print. (Hit Confirm.)
  2. Before the print is finished, Stop the print. (Hit Confirm.)

Expected behavior:

Expect to return to the Print Menu.

Actual behavior:

Stuck in a loop, per the video below.

Additional Information

I made a 2 minute video to show the issue.

I first start out with my own build, where, per the OEM Configuration.h file, both JYERSUI and USE_STOCK_DWIN_SET are defined.

You can see the loop.

Then, as an experiment, I compiled another build where I uncommented DWIN_CREALITY_LCD_JYERSUI

In that segment, you can see that this time, a message pops up after you stop a print, telling you to wait while the head parks.

Then you return to the Print menu.

(You can also see that, without the JYERSUI component, there is no "Confirm" to print.)

Last, I flashed BLTUBL-LA/Ender3V2_422BLT_UBL_LA.bin so that everything is vanilla.

The problem is there too.

https://streamable.com/07o067

LCh-77 commented 2 years ago

Thank you for finding the error, which allows us to improve Jacob's code. At first I couldn't confirm it, but later I saw that you're not using preview images. That was the difference, I had a mistake in the PrintDone confirm screen. It is now fixed.

LCh-77 commented 2 years ago

@Ergonomicmike This is another demonstration of what happens when this

image

It is not your firmware, it is Jacob's firmware, "A thief believes everybody steals"

Ergonomicmike commented 2 years ago

Confirmed here too. Thank you for fixing this so quickly. I am a beta-tester for an Aviation software company and I have found that making videos to demonstrate a problem helps the developers to see what's wrong.

Now that you found that this issue was related to not using Preview images, I wonder if the same is true with the "Confirm" to print dialogue? I can see how a developer might want users to confirm their choice of file if they can't see their choice.

If I knew how to code, I would investigate this for myself and change it locally.

Also thanks to you all for fixing - in your Release - the long-standing error in Mr. Meyer's Configuration.h that had incorrectly set the bed size for the Ender 3 v2.

LCh-77 commented 2 years ago

Confirmed here too. Thank you for fixing this so quickly. I am a beta-tester for an Aviation software company and I have found that making videos to demonstrate a problem helps the developers to see what's wrong.

You are welcome.