search

Jyers / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. | Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
http://marlinfw.org
GNU General Public License v3.0
2.14k stars 385 forks source link

append changelog to fulfill the license obligation #2079

Closed naonaono closed 1 year ago

naonaono commented 1 year ago

Reminding about missing "notices" for modifications on original work (violation of GPL-3.0)

Hello,

[Modification terms and conditions in license] The original work should be honored while the modifications on it should be attached with prominent notices as the license GPL-3.0 dictates. Your project is a forking project from MarlinFirmware/Marlin which adopts GPL-3.0 as its project license.
The modification terms and conditions of GPL-3.0 dictate that:

GPL-3.0:

... The work must carry prominent notices stating that you modified it, and giving a relevant date. ...

Therefore, we think the project is obligated to abide by the modification terms and conditions in GPL-3.0.

[Violation of modification terms and conditions] We run through your history, and it turns out that you have conducted modifications to the source files of original work while didn't provide prominent notices. You have 76 commits which conduct modifications to the files of original work, all of which are not declared in README.md.
According to the license terms and conditions above, it is regarded as license violation. Thus, to avoid potential legal risks, I would suggest you carry out prominent notices for the 76 commits.

[Recommended Fix] There are 2 recommended solutions to fulfill the modification related obligation of GPL-3.0:

  1. Git Mechanism.

    • Just put a note in the top directory, something like MODIFICATION.md, or any file but the license text and NOTICES, in order to give people who follow you the most latitude to comply with the license without making a mess,
    • Write "In compliance with the GPL-3.0 license: I declare that this version of the program contains my modifications, which can be seen through the usual "git" mechanism."

  2. Changelog Text.
    Or add changelog for modification to comply with the license.

For your convenience, I created a PR with by picking up modification-related commit messages. It adds a few lines in changelog without touching the codebase. Please be comfortable to check it out.

Full details of the report you could refer to the html file attached. Hope it helps!

If there is anything wrong in this reminding, I'm sorry for my bothering, and please feel free to close this PR.

Cheers!

Jyers commented 1 year ago

Thank you very much for this notice! I was unaware of this aspect of GPL-3.0. I also very much appreciate you creating the relevant changelog for me. I will merge this right away :)