Jyers / Marlin

Marlin is an optimized firmware for RepRap 3D printers based on the Arduino platform. | Many commercial 3D printers come with Marlin installed. Check with your vendor if you need source code for your specific machine.
http://marlinfw.org
GNU General Public License v3.0
2.14k stars 386 forks source link

Manual Bed Leveling Disable M420 #902

Closed eblieb closed 3 years ago

eblieb commented 3 years ago

Need to ensure M420 is set to M420 S0 before manual bed leveling or else it will mess up the bed leveling every time. I verified by running the bed leveling then manually setting M420 S0 and telling it to go to the same point and the Z height was different after disabling the leveling.

Jyers commented 3 years ago

#if HAS_LEVELING level_state = planner.leveling_active; set_bed_leveling_enabled(false); #endif Draw_Menu(ManualLevel);

I can assure you this is already the case. If the z height changes it must be from a different factor. What leveling system are you using?

eblieb commented 3 years ago

Where in the code is that? Using a bltouch with abl

On Tue, May 25, 2021, 12:33 Jyers @.***> wrote:

if HAS_LEVELING

level_state = planner.leveling_active; set_bed_leveling_enabled(false);

endif

Draw_Menu(ManualLevel);

I can assure you this is already the case. If the z height changes it must be from a different factor. What leveling system are you using?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Jyers/Marlin/issues/902#issuecomment-848030435, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE4D4LLCKODY5EN7NKHTQF3TPPGOBANCNFSM45POX4KA .

Jyers commented 3 years ago

https://github.com/Jyers/Marlin/blob/c4c58e3317045e3331c85abcb30ea4d425986f07/Marlin/src/lcd/dwin/creality_dwin.cpp#L1077

eblieb commented 3 years ago

Strange.. Must have been a glitch then

From: Jyers @.> Sent: Tuesday, May 25, 2021 12:39 To: Jyers/Marlin @.> Cc: eblieb @.>; Author @.> Subject: Re: [Jyers/Marlin] Manual Bed Leveling Disable M420 (#902)

https://github.com/Jyers/Marlin/blob/c4c58e3317045e3331c85abcb30ea4d425986f07/Marlin/src/lcd/dwin/creality_dwin.cpp#L1077

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Jyers/Marlin/issues/902#issuecomment-848036712 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AE4D4LP7FEUXTWUYM5P5XHDTPPHBXANCNFSM45POX4KA . https://github.com/notifications/beacon/AE4D4LJCNR4LM6D6ICN5HEDTPPHBXA5CNFSM45POX4KKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGKGAG2A.gif