search

Jypeli-JYU / Jypeli

A simple educational C# game programming library built on top of Silk.NET.
26 stars 4 forks source link

Fix bugs in MultiSelectWindow #12

Closed Anttifer closed 4 years ago

Anttifer commented 4 years ago

The number key button selection & default cancel action didn't work. This fixes them.

Also, the listeners created by MultiSelectWindow were never destroyed, and they would just live eternally in the SynchronousList for listeners in each Controller. They wouldn't get invoked if the window were removed since there is a check for that, but new ones would be added to the list every time the window is shown.

MultiSelectWindow is not the only class with this type of leak - e.g. Window itself has it too. Since there is no mechanism for automatically removing listeners whose associated context is destroyed, the listeners must be destroyed manually by any object that creates them.

I'll go through the Listen calls and submit pull requests accordingly, since there are not that many of them, but maybe in the future an automatic listener cleanup system should be added.

roeyskoe commented 4 years ago

Looks good, these different types of windows are used really rarely so not a big surprise if there exists a lot of bugs.