EntraptaJ
commented
4 years ago Sorry I missed this earlier. I think I know why this is failing and I'm not sure how it could be resolved without finding how to remove my hack for supporting commonJS modules, because without my dynamic module type all imported node modules not ESNext format give a XYZ does not export ABC, if you had something like this:
import { ABC } from 'XYZ'So to solve that and allow for compat with older modules or TypeScript projects with ESModule compat enabled I have to load all node_modules as dynamic modules with a dynamicinstanciate hook that manually imports with a createRequire and then returns the values on the object and spreads out anything withing imported.default. It's super hacky but it was the only way to achieve my goal of drop in support in most projects without any refactoring.
Here is how I load all "node_modules"
/**
* This dynamically imports the `node_modules` module and creates a dynamic module with all the same exports.
* @param url fileURL given by Node.JS
*/
export async function dynamicInstantiate(url: string) {
// Create a Node.JS Require using the `node_modules` folder as the base URL.
const require = createRequire(
`${url.split('/node_modules/')[0].replace('file://', '')}/node_modules/`,
);
// Import the module file path
let dynModule = require(url.replace(/.*\/node_modules\//, ''));
/**
* This is needed to allow for default exports in CommonJS modules.
*/
if (dynModule.default)
dynModule = {
...dynModule.default,
...dynModule,
};
const linkKeys = Object.keys(dynModule);
return {
exports: [...linkKeys, 'default'],
execute: (module: any) => {
module.default.set(dynModule);
// For all elements in the import set the module's key.
for (const linkKey of linkKeys) module[linkKey].set(dynModule[linkKey]);
},
};
}
armarti
Hey there, this is a neat project and could hopefully someday do away with needing ts-node for everything.
I want to open this as more of a TO-DO for when I or someone else finds time. Right now I'm using yarn2, which uses a virtual filesystem and doesn't have a node_modules folder. All packages are instead stored in
.zipfiles and extracted when needed.A few takeaways from my hour trying to get this to work with yarn2.0.0-rc.29 and node 13.9:
Yarn2's virtual filesystem is accessible via a few different routes but the simplest is by starting node as
node --require ./.pnp.jsfrom the project root. Delving into exactly what happens when.pnp.jsis hooked like this is a big TODO, but I believe it monkeypatches thefsmodule to automatically unzip packages whenever they're imported / required.The catch22 with using yarn2 + this neat package is:
package.jsonhas"type": "module",requireis not defined at startup. Since the CLI flag--require ...seems to literally userequire(...), this fails with an error.--require ./.pnp.js, none of the workspace's packages are available, meaning--loader=@k-foss/ts-esnoderesults inCannot find package '@k-foss/ts-esnode ...So maybe sometime later this month I'll have some bandwidth to tackle this. But compliments again for finding a way to leverage these new node features to potentially make typescript less painful.