Print console in develop/refactor

K-Mistele / seeker-of-the-sword

ascii-character adventure code written into console via python

Other

5 stars 0 forks source link

Print console in develop/refactor #59

Open K-Mistele opened 6 years ago

K-Mistele commented 6 years ago

Print console should also display (in red?) when monster attacks you. Ask Kyle for help with monster class if need be.

@Michael-N -- any thoughts on this?

Maybe we could have a warning print when the wraith gets close to you (for the first time only) -- I can write a method for the player or monster class to do this. Something like... A chill runs down your spine... An undead power draws near.

Michael-Naguib commented 6 years ago

@K-Mistele

First we need to fix the screen class to permit colors...
That will be very easy to implement... all we have to do is add the color string to the monster string passed to .console()

Michael-Naguib commented 6 years ago

Also something that would be good to do is split the configuration section into another file..

something like

import generateSettings

gameSettings = generateSettings() # asks the user ....

gameSettings["useColor"]  #access

Michael-Naguib commented 6 years ago

Work For refactoring

[ ] Printing to screen as a separate class AND file
[ ] Internal Game settings generation
[ ] Collision Detection as a separate class and file
[ ] Most global scope level functions should be assigned to classes
[ ] (recommended) player position, health,etc... be a property of the player
[ ] a class for handling player inventory ... maybe implemented as a property of player
[ ] Split credits as separate files and create a class that runs credits on init...

Some of these will need to be sub branched however merge very soon as refactoring inherently will present complex merge conflicts

Michael-Naguib commented 6 years ago

Update

Some sections of code will have to be rewritten:
Middleware code written to help in the refactoring by keeping limited compatibility with the old code through common variable names when applicable. Simplify to class calls when finished with refactoring and rewriting and splitting.
[ ] mob collision detection: does not just do collision detection
[ ] player move: this function literally is 300 lines long 1/3 of the code and redundant, it needs to be split according to groups of functionality... otherwise it is hard to manage and update

K-Mistele commented 6 years ago

@Michael-N Should I refactor mob collisions to be part of the world class? Because the problem is that it needs to be part of the mob move function because it's essential in determining behavior for how mobs move