Make fetching on-call schedules resilient and display schedule names

jhuiting commented 2 years ago

First of all, thank you for creating this great plugin! Really like the integration so far.

While testing this out with a live system I've noticed some small things that could be improved, hence this MR:

When no ownerTeam is defined for a schedule you'll get a name is undefined error
When multiple schedules refer to an owerTeam it's really unclear why names show up multiple times (e.g. when multiple schedules are overlap). My suggestion there would be to add the schedule to the name to indicate this.

Happy to make adjustments when needed.

K-Phoen commented 2 years ago

Hey, thanks for the PR!

Glad this plugin can be of use for you :)

I took the liberty to fix a few tsc/linting issue as well as making the responder/schedule formatting configurable: different contexts will have different needs/preferences, so I figured it was probably better to not make any assumption and let people decide what to display.

jhuiting commented 2 years ago

Looks good, this is much better then what I came up with! I'll give it a shot rightaway, thank you!

K-Phoen / backstage-plugin-opsgenie

Make fetching on-call schedules resilient and display schedule names #98