search

K-Phoen / dark

(grafana) Dashboards As Resources in Kubernetes
MIT License
428 stars 21 forks source link

Fix Gauge Converter #230

Closed jlevesy closed 1 year ago

jlevesy commented 1 year ago

What does this PR do?

Couple of tiny fixes for the JSON to YAML converter regarding gauges.

Hope this helps :)

codecov-commenter commented 1 year ago

Codecov Report

Merging #230 (85b1305) into master (339a3c5) will not change coverage. Report is 1 commits behind head on master. The diff coverage is 50.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/K-Phoen/dark/pull/230/graphs/tree.svg?width=650&height=150&src=pr&token=GSxlROtzzx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=K%C3%A9vin+Gomez)](https://app.codecov.io/gh/K-Phoen/dark/pull/230?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=K%C3%A9vin+Gomez) ```diff @@ Coverage Diff @@ ## master #230 +/- ## ======================================= Coverage 40.99% 40.99% ======================================= Files 39 39 Lines 2583 2583 ======================================= Hits 1059 1059 Misses 1484 1484 Partials 40 40 ``` | [Files Changed](https://app.codecov.io/gh/K-Phoen/dark/pull/230?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=K%C3%A9vin+Gomez) | Coverage Δ | | |---|---|---| | [internal/pkg/converter/gauge.go](https://app.codecov.io/gh/K-Phoen/dark/pull/230?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=K%C3%A9vin+Gomez#diff-aW50ZXJuYWwvcGtnL2NvbnZlcnRlci9nYXVnZS5nbw==) | `55.00% <50.00%> (ø)` | |