search

K-Phoen / grabana

User-friendly Go library for building Grafana dashboards
MIT License
680 stars 69 forks source link

adding all fields that grafana sdk's board supports to Dashboard struct #224

Closed karthik-kasarapu closed 1 year ago

karthik-kasarapu commented 1 year ago

I have a use case to access the templating data from the JSON object returned in GetDashboardByTitle method here. So adding the board struct that we get from grafana sdk to include all the fields.

codecov[bot] commented 1 year ago

Codecov Report

Merging #224 (44d6788) into master (8a7600e) will not change coverage. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/K-Phoen/grabana/pull/224/graphs/tree.svg?width=650&height=150&src=pr&token=eJwYXNp5jD&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=K%C3%A9vin+Gomez)](https://app.codecov.io/gh/K-Phoen/grabana/pull/224?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=K%C3%A9vin+Gomez) ```diff @@ Coverage Diff @@ ## master #224 +/- ## ======================================= Coverage 90.07% 90.07% ======================================= Files 92 92 Lines 6934 6934 ======================================= Hits 6246 6246 Misses 543 543 Partials 145 145 ``` | [Impacted Files](https://app.codecov.io/gh/K-Phoen/grabana/pull/224?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=K%C3%A9vin+Gomez) | Coverage Δ | | |---|---|---| | [dashboards.go](https://app.codecov.io/gh/K-Phoen/grabana/pull/224?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=K%C3%A9vin+Gomez#diff-ZGFzaGJvYXJkcy5nbw==) | `60.86% <ø> (ø)` | |
karthik-kasarapu commented 1 year ago

GetDashboardByTitle uses URL /api/search?type=dash-db&query= which doesn't return full json model of dashboard. Hence closing the PR