search

K-Phoen / grabana

User-friendly Go library for building Grafana dashboards
MIT License
680 stars 69 forks source link

Allow ProjectName to be configurable on Stackdriver alerts #229

Closed ronanbarrett closed 1 year ago

ronanbarrett commented 1 year ago

Utilising the now exposed ProjectName as added in SDK https://github.com/K-Phoen/sdk/commit/e77b6356006cbe3533e72da4479810cad23a6103.

Note: This PR is referring to a specific SDK commit as a release isn't available yet. Please create a new release of the SDK and I'll fix this PR.

codecov[bot] commented 1 year ago

Codecov Report

Merging #229 (d07fe1f) into master (8a7600e) will increase coverage by 0.01%. Report is 1 commits behind head on master. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/K-Phoen/grabana/pull/229/graphs/tree.svg?width=650&height=150&src=pr&token=eJwYXNp5jD&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=K%C3%A9vin+Gomez)](https://app.codecov.io/gh/K-Phoen/grabana/pull/229?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=K%C3%A9vin+Gomez) ```diff @@ Coverage Diff @@ ## master #229 +/- ## ========================================== + Coverage 90.07% 90.08% +0.01% ========================================== Files 92 92 Lines 6934 6941 +7 ========================================== + Hits 6246 6253 +7 Misses 543 543 Partials 145 145 ``` | [Files Changed](https://app.codecov.io/gh/K-Phoen/grabana/pull/229?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=K%C3%A9vin+Gomez) | Coverage Δ | | |---|---|---| | [alert/queries/stackdriver/stackdriver.go](https://app.codecov.io/gh/K-Phoen/grabana/pull/229?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=K%C3%A9vin+Gomez#diff-YWxlcnQvcXVlcmllcy9zdGFja2RyaXZlci9zdGFja2RyaXZlci5nbw==) | `100.00% <100.00%> (ø)` | | | [decoder/alert\_targets.go](https://app.codecov.io/gh/K-Phoen/grabana/pull/229?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=K%C3%A9vin+Gomez#diff-ZGVjb2Rlci9hbGVydF90YXJnZXRzLmdv) | `93.02% <100.00%> (+0.09%)` | :arrow_up: |