search

K-Phoen / grabana

User-friendly Go library for building Grafana dashboards
MIT License
680 stars 69 forks source link

Introduce support to cloudwatch alert rule provisioning #233

Open themarcelor opened 1 year ago

themarcelor commented 1 year ago

As a follow-up of https://github.com/K-Phoen/grabana/pull/227

This PR introduces support for Alert Rule provisioning with CloudWatch queries.

Please share your thoughts.

codecov[bot] commented 1 year ago

Codecov Report

Attention: Patch coverage is 89.36170% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 90.08%. Comparing base (6867a4a) to head (c54fa57). Report is 54 commits behind head on master.

:exclamation: Current head c54fa57 differs from pull request most recent head 4bfb6da. Consider uploading reports for the commit 4bfb6da to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/K-Phoen/grabana/pull/233/graphs/tree.svg?width=650&height=150&src=pr&token=eJwYXNp5jD&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=K%C3%A9vin+Gomez)](https://app.codecov.io/gh/K-Phoen/grabana/pull/233?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=K%C3%A9vin+Gomez) ```diff @@ Coverage Diff @@ ## master #233 +/- ## ========================================== - Coverage 90.08% 90.08% -0.01% ========================================== Files 92 93 +1 Lines 6941 6988 +47 ========================================== + Hits 6253 6295 +42 - Misses 543 548 +5 Partials 145 145 ``` | [Files](https://app.codecov.io/gh/K-Phoen/grabana/pull/233?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=K%C3%A9vin+Gomez) | Coverage Δ | | |---|---|---| | [alert/queries/cloudwatch/cloudwatch.go](https://app.codecov.io/gh/K-Phoen/grabana/pull/233?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=K%C3%A9vin+Gomez#diff-YWxlcnQvcXVlcmllcy9jbG91ZHdhdGNoL2Nsb3Vkd2F0Y2guZ28=) | `100.00% <100.00%> (ø)` | | | [alert/queries.go](https://app.codecov.io/gh/K-Phoen/grabana/pull/233?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=K%C3%A9vin+Gomez#diff-YWxlcnQvcXVlcmllcy5nbw==) | `82.75% <0.00%> (-17.25%)` | :arrow_down: |
themarcelor commented 12 months ago

This PR is blocked by this other PR: https://github.com/K-Phoen/grabana/pull/227

@K-Phoen please check #227 when you have a chance 🙏🏼