K-S-V / Scripts

Collection of my scripts
GNU General Public License v3.0
634 stars 226 forks source link

"Found 0 fragments" after successfully downloading video file/fragments #36

Closed Frankst2 closed 8 years ago

Frankst2 commented 10 years ago

I've tried to download a video from a website with the current version of the script, but then the script confused me with a, what I think, misleading error message:

"F:\video_test2>php AdobeHDS.php --manifest "http://sport1_event03-lh.akamaihd.net/z/EVENT03_1@140376/manifest.f4m?start=1398017640&end=1398024900&start=1398035438&hdnea=st=1398036338~exp=1398036638~acl=*~hmac=ccf77b44ff6e3c993f1bc20da7ac1672e681ed79c9f3ac80f98e50f42eb3c0cd&g=SCHSPCBVHXEM&hdcore=3.2.0&plugin=jwplayer-3.2.0.1" --delete --auth "hdntl=exp=1398122741~acl=%2f*~data=hdntl~hmac=e34a7815f8d0ffe0ab6eef88151373f298360cb8b8b6cab53ccf6b0338fb6459&start=1398017640&end=1398024900&start=1398035438&als=0,3,NaN,3,0,NaN,0,0,0,18,f,0,7260,f,s,SCHSPCBVHXEM,3.2.0,18&hdcore=3.2.0&plugin=jwplayer-3.2.0.1" --useragent "Mozilla/5.0 (Windows NT 6.3; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0"

                            KSV Adobe HDS Downloader

Processing manifest info....
Quality Selection:
 Available: 2628 1328 640 340
 Selected : 2628
Fragments Total: 233004150, First: 233002941, Start: 233002941, Parallel: 8
Downloading 233004150/233004150 fragments
Found 0 fragments
Finished

The "Found 0 fragments" part is wrong here I think, after all it downloaded all fragment files with the file names from "856259d3cb6ac9ee73e2514e35ca643d_2500_a5e3d0c41aaf47d4-p_Seg1-Frag233002941" to "856259d3cb6ac9ee73e2514e35ca643d_2500_a5e3d0c41aaf47d4-p_Seg1-Frag233004150" and also the resulting .flv file looks fine from what I can see. So it's just the error message being confusing here. Actually I'm not sure why it continues at this point, after all the code should abort with 0 fragments?:

LogInfo("Found $fragCount fragments");

  if (!$f4f->processed)
    {
      // Process available fragments
      if ($fragCount < 1)
          exit(1);
K-S-V commented 10 years ago

The specified code relates to offline processing of locally saved fragments which is not true in the case of live streams. it's just an informational message not a warning or error message.

Frankst2 commented 10 years ago

Ah ok, this recording counts (technically) as live stream then, didnt know that. So I guess what's left of this bug is to not display this message when recording a live stream (of course a very minor issue).