K0bus / CreativeManager

Free Spigot plugin for manage action in Creative
6 stars 12 forks source link

Events of priority monitor are getting modified #30

Closed Thorinwasher closed 8 months ago

Thorinwasher commented 8 months ago

Describe the bug An eventlistener of priority MONITOR should never modify the event. I found muliple instances where this was the case. Why does this matter? Because other plugins could also listen to the event at monitor priority. Modifying the event at the same priority means that there's a chance that those plugins recieve invalid input on what happened with the event.

To Reproduce By looking into the code, I found this behavior in these following listeners:

Expected behavior Have those listeners be on a different priority

Screenshots N/A

Server information:

Hardware information :

Smartphone (please complete the following information):

Additional context

K0bus commented 8 months ago

Fixed in #31