search

K0lb3 / UnityPy

UnityPy is python module that makes it possible to extract/unpack and edit Unity assets
MIT License
810 stars 123 forks source link

CI: fix names of linux wheels #129

Closed Parnassius closed 2 years ago

Parnassius commented 2 years ago

The last few releases of UnityPy are missing linux wheels on PyPI. Digging into the GitHub Actions Logs I noticed that, at least for 1.9.14, the wheels build correctly, but they fail to upload on PyPI due to an unsupported platform tag 'manymanylinux2014_2_17_aarch64' (the correct tag should be manylinux_2_17_aarch64).

Logs from https://github.com/K0lb3/UnityPy/runs/7925016550?check_suite_focus=true ``` ERROR HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/ Binary wheel 'unitypy-1.9.14-cp37-cp37m-manymanylinux2014_2_17_aarch64.whl' has an unsupported platform tag 'manymanylinux2014_2_17_aarch64'. ```

Simply removing the renaming step from the workflow file seems to fix this.

K0lb3 commented 2 years ago

Oh, indeed, I didn't notice that they finally fixed the issue. Some months back cibuildwheel produced manylinux14 wheels named as linux, so the workflow segment to be removed fixed that issue at that time.

K0lb3 commented 2 years ago

So, thanks for finding the issue and opening the PR.