search

K0p1-Git / cloudflare-ddns-updater

Dynamic DNS (DDNS) service based on Cloudflare! Access your home network remotely via a custom domain name without a static IP! Written in pure BASH~
MIT License
1.33k stars 372 forks source link

Add ntfy.sh notification provider #90

Open Avi0n opened 2 months ago

Avi0n commented 2 months ago

Added ntfy.sh notication provider. All it needs is the ntfy topic. ntfy.sh docs for reference: https://docs.ntfy.sh/publish/

ndrone commented 2 months ago

Could this replace all the other notification types?

Avi0n commented 2 months ago

@ndrone Sorry, what do you mean by replace? Do you mean remove all other notification providers other than ntfy.sh? Or that my code has a problem?

ndrone commented 2 months ago

@ndrone Sorry, what do you mean by replace? Do you mean remove all other notification providers other than ntfy.sh? Or that my code has a problem?

yes replace all other notification providers.

Avi0n commented 2 months ago

Ah I see. I feel Slack and Discord would still be useful since they are much more popular platforms than ntfy.sh, but I will of course leave it up to the maintainer.

K0p1-Git commented 2 months ago

while I think its a good addition, slack and discord are still common. Hence, I don't think it should be removed.

Avi0n commented 2 months ago

That was my thought as well. This PR doesn't remove any notification providers, it just adds ntfy.

I realized ntfy also supports self-hosting the server, so I added support for custom URI's as well.