search

K1rakishou / Kuroba-Experimental

Free and open source image board browser
GNU General Public License v3.0
629 stars 36 forks source link

New reply layout/toolbar/search/etc bugs mega thread #1029

Open K1rakishou opened 2 months ago

K1rakishou commented 2 months ago

Post all the broken shit here. Oh yeah, the database schema was changed so it's a good idea to make a backup before updating to this beta. Also, these are not all of the improvements, this is just an initial version where everything seems to work. More stuff to come.

alkamine commented 2 months ago

For the past two updates, the application has been freezing for me whe I have been trying to submit a reply in a thread. This happens before the send button is pressed and even before text is entered sometimes. This results in requiring me to kill the application and start it again. this has never happened before the updates to the UI.

a84r7a3rga76fg commented 2 months ago

It was better before. Highlighting the text has become so much more difficult because of the implementation of the text magnifier. The side bar jump around like a frog.

a84r7a3rga76fg commented 2 months ago

It breaks the keyboard too. No longer suggests words because it defaults to numbers. Have to restart the app.

Change back to what it was before, this is ridiculous.

K1rakishou commented 1 month ago

@alkamine

For the past two updates, the application has been freezing for me whe I have been trying to submit a reply in a thread.

I did some changes that may potentially fix this (I can't reproduce it locally so I can't test it). If this keeps happening then I will need:

  1. A video of when this happens.
  2. Logs taken right after this happens (or at most 5 minutes after).

@a84r7a3rga76fg

Highlighting the text has become so much more difficult because of the implementation of the text magnifier. The side bar jump around like a frog.

I made some changes so that drawer/thread pane cannot be opened by doing slide gestures inside of the reply layout. Should be easier to select text now.

It breaks the keyboard too. No longer suggests words because it defaults to numbers. Have to restart the app.

I've switched the TextField which is used by ReplyInput to the new TextFieldV2 (from Compose) which doesn't have this problem. However, this text field doesn't support text colorization (yet). I will bring it back once they add support.

Try the latest beta.

alkamine commented 1 month ago

@alkamine

For the past two updates, the application has been freezing for me whe I have been trying to submit a reply in a thread.

I did some changes that may potentially fix this (I can't reproduce it locally so I can't test it). If this keeps happening then I will need:

  1. A video of when this happens.
  2. Logs taken right after this happens (or at most 5 minutes after).

@a84r7a3rga76fg

Highlighting the text has become so much more difficult because of the implementation of the text magnifier. The side bar jump around like a frog.

I made some changes so that drawer/thread pane cannot be opened by doing slide gestures inside of the reply layout. Should be easier to select text now.

It breaks the keyboard too. No longer suggests words because it defaults to numbers. Have to restart the app.

I've switched the TextField which is used by ReplyInput to the new TextFieldV2 (from Compose) which doesn't have this problem. However, this text field doesn't support text colorization (yet). I will bring it back once they add support.

Try the latest beta.

Thanks, seems to have fixed most of it, I saw a ot of freezing when the back button was pressed to return to the catalog after making a post, now its about 50% of what it was. Still happnes though.

New issue though: the text in the comment field when replying to a post persists across posts (stays in the comment box) on the same thread. FOr example, If I reply "hello" to someone, the next time I go to post in that thread, the comment field shows

123456789 (previosuly replied to post number) "hello"

can you get rid of this? its annoting to have to select and delete your previous comment tat youve already posted from a fresh reply/post

K1rakishou commented 1 month ago

@alkamine

I saw a ot of freezing when the back button was pressed to return to the catalog after making a post, now its about 50% of what it was.

You mean like, you start sending a post and then go back to catalog before it finishes?

can you get rid of this? its annoting to have to select and delete your previous comment tat youve already posted from a fresh reply/post

Yeah, I will fix it.

alkamine commented 1 month ago

New Bug idenified: Voice input via custom keyboards or voice input applications does not work. whatever you say is just ignored and not put into the reply/new post field

alkamine commented 1 month ago

@alkamine

I saw a ot of freezing when the back button was pressed to return to the catalog after making a post, now its about 50% of what it was.

You mean like, you start sending a post and then go back to catalog before it finishes?

or if you decide not to post, if you type something in the comment/reply field, and hit the android back button on the navigation bar, instead of taking you back to the catalog, it freezes the whole app

a84r7a3rga76fg commented 1 month ago

The inputted text multiples itself by two if 4chan rejects your post

alkamine commented 1 month ago

New problem: as of yesterday, about 50% of the time posts fail, and when they do, the text in the comment box is doubled if you try to post again, which then posts the same comment twice. the app is very broken as of now.= in regards to the coment box and overall stability

buggerlol commented 1 month ago

If you try to add a new file by tapping the paperclip, and then decide you don't want to attach a file and back out, this error pops up. There shouldn't be any error shown in this case.

Screenshot_20240322_210231

Another issue: if you tap one of the images stored in the reply box to view the preview and the image is portrait oriented, it will only show a zoomed in segment of the center of the image, like so: Screenshot_20240322_210556

Also, I can't figure out how to access the name and options fields with the new reply box.

New problem: as of yesterday, about 50% of the time posts fail,

I had posts failing with the old reply box, it's actually why I tried updating. The doubling of comments didn't happen, however.

buggerlol commented 1 month ago

On Samsung Galaxy S23+, using the default keyboard, swipe-typing in the reply box doesn't add spaces automatically after each word. (This is the default behavior for URL bars.)

alkamine commented 1 month ago

If you try to add a new file by tapping the paperclip, and then decide you don't want to attach a file and back out, this error pops up. There shouldn't be any error shown in this case.

Screenshot_20240322_210231

Another issue: if you tap one of the images stored in the reply box to view the preview and the image is portrait oriented, it will only show a zoomed in segment of the center of the image, like so: Screenshot_20240322_210556

Also, I can't figure out how to access the name and options fields with the new reply box.

New problem: as of yesterday, about 50% of the time posts fail,

I had posts failing with the old reply box, it's actually why I tried updating. The doubling of comments didn't happen, however.

the new UI isnt intuitive at all, you have to swipe up from below on the right panel where the post and select image options are. the app is currently really broken, fails posting 5/10 times and then doubles the text.

K1rakishou commented 1 month ago

Text doubling fixed in https://github.com/K1rakishou/Kuroba-Experimental/commit/b99530711e58b1ba3668549f8bb59491b15a7975

alkamine commented 1 month ago

Text doubling fixed in b995307

Just checked and yes, thanks for the prompt fix. App is still crashing when the back button is pressed and the post dialog is open

happapa commented 1 month ago

The new reply box has broken Japanese input completely. Using the keyboard's suggestion bar is basically mandatory when writing Japanese. On Gboard, the suggestion bar refuses to show any suggestions at all. On Samsung Keyboard, the suggestions show, but tapping them doesn't actually write text into the box. I wouldn't be surprised if other foreign languages like Chinese were also broken.

a84r7a3rga76fg commented 1 month ago

Older layout didn't require the text editor to be maximized to upload files via URLs

K1rakishou commented 1 month ago

Older layout didn't require the text editor to be maximized to upload files via URLs

Yeah, this is already fixed with the new toolbar.

alkamine commented 1 month ago

Older layout didn't require the text editor to be maximized to upload files via URLs

Yeah, this is already fixed with the new toolbar.

app is still freezing when the back button on the navigation bar is tapped to return to the catalog

a84r7a3rga76fg commented 3 weeks ago

Highlighting text is still impossible. It always assumes I'm doing the back button gesture which crashes the program.

K1rakishou commented 3 weeks ago

@a84r7a3rga76fg Do you have gesture navigation enabled in Android settings?

a84r7a3rga76fg commented 2 weeks ago

I do and I will not turn if off

K1rakishou commented 2 weeks ago

@alkamine Ok so I actually didn't manage to reproduce your issue, maybe it fixed itself. If not then I will need a video or something like that to see what's going on.

alkamine commented 2 weeks ago

New Issue: After latest update today, bottom navigation bar is totally gone, with no option to put it back in the settings. its now permanently in the pullable section with the hamburger menu.

Can you please add an option to put it back? I cannot navigate with the new UI.

K1rakishou commented 2 weeks ago

Bookmarks and global search will eventually be moved to other more easily accessible places, so shouldn't be an issue.

alkamine commented 2 weeks ago

Bookmarks and global search will eventually be moved to other more easily accessible places, so shouldn't be an issue.

As of now the ui takes many more steps to navigate what was once a one click process to check the threads you are participating in, and respond to replies etc. its a two handed job now on some phones for some users, like the previous generation Pixels with a curved screen on the sides because reaching over to the hamburger menu with your thumb doesnt trigger it because of the curve.

K1rakishou commented 2 weeks ago

@alkamine You can just swipe from left to right in the middle of the screen to open the drawer. But this only works in catalogs. In threads you can longtap the left edge and then drag to the right.

alkamine commented 2 weeks ago

@alkamine You can just swipe from left to right in the middle of the screen to open the drawer. But this only works in catalogs. In threads you can longtap the left edge and then drag to the right.

its still an addition of more unneeded steps. And again, some of us have curved screens, which are hard to accurately tap on the edges. it used to be a single tap. What is the reason the UI is no longer configurable in this regard?

K1rakishou commented 2 weeks ago

@alkamine If you mean accessing bookmarks/global search now takes more clicks then it will be fixed eventually. The bookmarks will be merged into the drawer and global search will be a part of the catalog search. It will take some time, though, because it's a lot of work.

alkamine commented 2 weeks ago

@alkamine If you mean accessing bookmarks/global search now takes more clicks then it will be fixed eventually. The bookmarks will be merged into the drawer and global search will be a part of the catalog search. It will take some time, though, because it's a lot of work.

Why isnt there an option to set the UI back to how it was? it should be trivial. I would just downgrade but the exports of the new version, with all my filters and other configurations are not compatible with the previous version. no idea why you did that either. really hampers the user experience, they cant go back even if they wanted to.

Nekudot commented 1 week ago

I don't want to make a new issue for this, and I think it can go here, so... the small notification number by the back button now shows all replies from all bookmarked threads instead of only (You)s, surely that's not intended, right?

Edit: I noticed the number is yellow and becomes orange when you have a reply, at least on the theme I'm using, so now I know it's not a bug. A bit misleading and very distracting compared to how it worked before

K1rakishou commented 1 week ago

@Nekudot That's how it worked before, though.

Nekudot commented 1 week ago

@K1rakishou This is what I mean, on the left is an old screenshot from last year, in the middle is a random screenshot from a month or so ago, and on the right is how it appears today. I didn't even remember there used to be a number, because it was pretty muted. In both the left and middle images, the number becomes bright when you have a reply, but now it always has this bright background under it, and it barely changes color when you receive a reply. It's not that big of a deal, but it did change after the latest update. ResizedImage_2024-05-04_04-19-45_2572

Edit: Thanks, I set bookmark_counter_normal_color in the theme to a more subdued color and has_replies_color to a brighter one. Good enough for me. I tried transparent too but it obviously got rid of the reply numbers in the bookmarks as well.

K1rakishou commented 1 week ago

Oh I see what you mean. Yeah, I did change the colors. Now it uses the same colors as the numbers of read/unread bookmarks on the Bookmarks screen/drawer. These three:

  val bookmarkCounterNotWatchingColor: Int,
  val bookmarkCounterHasRepliesColor: Int,
  val bookmarkCounterNormalColor: Int,

Previously it used transparent black color when there are no reply and theme's accent color when there are replies.