K1rakishou / Kuroba-Experimental

Free and open source image board browser
GNU General Public License v3.0
675 stars 38 forks source link

Find a better fast scroller (FastScroller uses incorrect RecyclerView's height) #33

Closed K1rakishou closed 4 years ago

K1rakishou commented 4 years ago

There is some kind of offset, probably because of the toolbar/bottomnavview or because of the window insets.

K1rakishou commented 4 years ago

Maybe this one https://github.com/davideas/FlexibleAdapter/blob/10933e8501a15f6fc9c6ecdfafc4bb8732a58e34/flexible-adapter/src/main/java/eu/davidea/fastscroller/FastScroller.java

K1rakishou commented 4 years ago

Or maybe this one https://github.com/timusus/RecyclerView-FastScroll/tree/master/recyclerview-fastscroll/src/main/java/com/simplecityapps/recyclerview_fastscroll/views

K1rakishou commented 4 years ago

FastScroller is broken.

K1rakishou commented 4 years ago

Alright, new fast scroller isn't needed for now at least. The scrolling should be fine now. Fixed in https://github.com/K1rakishou/Kuroba-Experimental/commit/916e499e08e3b34d3fea2273e5a4131d1a86cc08