K1rakishou / Kuroba-Experimental

Free and open source image board browser
GNU General Public License v3.0
686 stars 40 forks source link

Feature Request - make status bar transparent on devices with notch/punch hole #905

Open Ciancy28 opened 1 year ago

Ciancy28 commented 1 year ago

Currently, KurobaEx makes the status bar transparent and draws content behind it on devices with a regular screen, such as my Sony Xperia Z5 Compact:
Screenshot_20230627-224801_KurobaEx-fdroid But on devices with a punch hole camera or notch, such as my Google Pixel 4a, the status bar is just black with no transparency at all Screenshot_20230627-224808_KurobaEx-fdroid I'm not sure if this is intended behaviour or not, or if there's a reason for this behaviour difference between screen types, but I suggest making the status bar transparent on all devices, either by default or as an option.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Ciancy28 commented 1 year ago

Dear bot This issue/feature request is still relevant and therefore I wish for it to stay open

K1rakishou commented 1 year ago

It should be transparent on all phones. If it isn't transparent for you then your phone doesn't support the official API.

Ciancy28 commented 1 year ago

It should be transparent on all phones. If it isn't transparent for you then your phone doesn't support the official API.

It's a Google pixel running stock android, and transparent status bar works on every other app, there's no way it doesn't support the official api Clearly not a device-side problem, my guess is that the app is programmed to only render up to a certain screen length maybe? So the issue is only present on phones with a high aspect ratio

K1rakishou commented 1 year ago

my guess is that the app is programmed to only render up to a certain screen length maybe?

There is no such API. You just tell the window to allow drawing behind the system content and that's it. Everything else is done by Android itself.

Ciancy28 commented 1 year ago

I installed the app on appetize.io, which uses an emulated almost 100% AOSP build of android and selected a punch hole notch as display cutout in developer options Screenshot_20230811-144306 This is further proof that it's not a problem limited to Google Pixels.
You could also test on the android studio emulator I think and it would probably be the same, but I don't have access to a computer right now.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Ciancy28 commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

would still like to see this implemented keep open

basketweavr commented 1 year ago

Same issue here on MIUI of all things. MIUI 14 based on Android 13 to be specific. I've used this exact same theme since back when this device was on MIUI 12.5.x, it behaved normally back then. Other apps which change the status bar color like Tachiyomi, Anki or Chromium based browsers work normally.

image

image

And I can confirm it's related to the punch-hole cutout settings, since the size of the black bar changed when I altered the simulated notch cutout size in Android's developer options.

stale[bot] commented 8 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.