Fix oci_util:to_num and uncomment test for it.

K2InformaticsGmbH / erloci

Erlang Oracle native driver - DEPRECATED, see https://github.com/K2InformaticsGmbH/oranif instead

Apache License 2.0

37 stars 11 forks source link

Closed sergej-klimenko closed 9 years ago

sergej-klimenko commented 9 years ago

Hi, seems that oci_util:to_num is somewhat broken... Tried to fix and now uncommented test passed.

c-bik commented 9 years ago

Thanks for this :+1: ! Looks good.

Left some comments for you for cosmetics before I merge.

Will you please also write specs for new function? I have planned to add specs to rest of APIs before next release.

sergej-klimenko commented 9 years ago

Thanks for your comments! Done.

c-bik commented 9 years ago

Perfect, thanks! Merging as soon as I test it out in couple platforms I have at my disposal