K2InformaticsGmbH / smpp_parser

A parser for SMPP protocol PDUs
Apache License 2.0
3 stars 1 forks source link

Reason: assertEqual (2) #57

Closed walter-weinmann closed 6 years ago

walter-weinmann commented 6 years ago
=== Reason: {assertEqual,
                     [{module,smpp_test_utils},
                      {line,66},
                      {expression,"NewBin"},
                      {expected,
                          <<0,0,0,83,128,0,1,3,0,0,0,0,0,0,0,1,116,104,105,
                            115,95,99,111,117,108,100,95,98,101,95,97,95,109,
                            101,115,115,97,103,101,95,105,100,0,0,29,0,31,109,
                            121,95,97,100,100,105,116,105,111,110,97,108,95,
                            115,116,97,116,117,115,95,105,110,102,111,95,116,
                            101,120,116,0,4,37,0,1,0>>},
                      {value,
                          <<0,0,0,83,128,0,1,3,0,0,0,0,0,0,0,1,116,104,105,
                            115,95,99,111,117,108,100,95,98,101,95,97,95,
                            109,101,115,115,97,103,101,95,105,100,0,4,37,0,
                            1,0,0,29,0,31,109,121,95,97,100,100,105,116,105,
                            111,110,97,108,95,115,116,97,116,117,115,95,105,
                            110,102,111,95,116,101,120,116,0>>}]}
  in function  smpp_test_utils:'-pack_unpack/1-fun-1-'/2 (d:/K2/smpp_parser_idea/smpp_parser/_build/test/lib/smpp_parser/test/src/smpp_test_utils.erl, line 66)
  in call from compacted_data_sm_resp_SUITE:test_compacted/1 (d:/K2/smpp_parser_idea/smpp_parser/_build/test/lib/smpp_parser/test/generated/ct/compacted_data_sm_resp_SUITE.erl, line 53)
  in call from test_server:ts_tc/3 (test_server.erl, line 1546)
  in call from test_server:run_test_case_eval1/6 (test_server.erl, line 1062)
  in call from test_server:run_test_case_eval/9 (test_server.erl, line 994)

Example:

 {"data_sm_resp_issue_57",
  "00 00 00 53 80 00 01 03 00 00 00 00 00 00 00 01 74 68 69 73 5F 63 6F 75 6C "
  "64 5F 62 65 5F 61 5F 6D 65 73 73 61 67 65 5F 69 64 00 00 1D 00 1F 6D 79 5F "
  "61 64 64 69 74 69 6F 6E 61 6C 5F 73 74 61 74 75 73 5F 69 6E 66 6F 5F 74 65 "
  "78 74 00 04 25 00 01 00"}
c-bik commented 6 years ago

Looks like it is fixed now without doing anything specifically for it!

      smpp: encode_decode_test_ (data_sm_resp_issue_57)...ok
      smpp: packunpack_test_ (data_sm_resp_issue_57)...ok

@walter-weinmann can you please confirm?