search

K7MDL2 / KEITHSDR

Teensy4.X with PJRC audio card Arduino based SDR Radio project.
54 stars 11 forks source link

Compilation error with USE_RS_HFIQ not defined #8

Closed G3ZQC closed 2 years ago

G3ZQC commented 2 years ago

Using the Arduino IDE get the following compilation error when "USE_RS_HFIQ" is not defined:

Controls.cpp: In function 'void VFO_AB()': Controls.cpp:503: error: 'RS_HFIQ' was not declared in this scope if (RS_HFIQ.find_new_band(old_VFOB, &curr_band)) // return the updated band index for the new freq ^ Only discovered this by accident. I thought that USE_RF_HFIQ had been defined, but that was in your personal definitions.

Jim G3ZQC

K7MDL2 commented 2 years ago

I fixed that last night, please pull down the latest.

Sent from my T-Mobile 4G LTE Device Get Outlook for Androidhttps://aka.ms/ghei36

From: G3ZQC @.> Sent: Monday, May 9, 2022 1:04:43 PM To: K7MDL2/KEITHSDR @.> Cc: Subscribed @.***> Subject: [K7MDL2/KEITHSDR] Compilation error with USE_RS_HFIQ not defined (Issue #8)

Using the Arduino IDE get the following compilation error when "USE_RS_HFIQ" is not defined:

Controls.cpp: In function 'void VFO_AB()': Controls.cpp:503: error: 'RS_HFIQ' was not declared in this scope if (RS_HFIQ.find_new_band(old_VFOB, &curr_band)) // return the updated band index for the new freq ^ Only discovered this by accident. I thought that USE_RF_HFIQ had been defined, but that was in your personal definitions.

Jim G3ZQC

— Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FK7MDL2%2FKEITHSDR%2Fissues%2F8&data=05%7C01%7C%7C3a0124ad410b4365e4cd08da31f728e2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637877234849432627%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=7a9bFZDihBvqRbcBKI1TeOCuVKoiQ0sAvTrmhNm%2FyWM%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAPLVE7HXQNEKJG5A7ZN6ZPLVJFVVXANCNFSM5VPK52BQ&data=05%7C01%7C%7C3a0124ad410b4365e4cd08da31f728e2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637877234849432627%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=RCWZJsNamhZQfE1Ocjs%2BnG1be99ObdU4XPSwvG1BgZ8%3D&reserved=0. You are receiving this because you are subscribed to this thread.Message ID: @.***>

G3ZQC commented 2 years ago

Still fails with me:
Controls.cpp:501 #ifndef USE_RS_HFIQ // Compute the band index for the new target band an ensure it is in limits if (RS_HFIQ.find_new_band(old_VFOB, &curr_band)) // return the updated band index for the new freq

else

    if (find_new_band(old_VFOB, &curr_band))
#endif

Loos like #ifndef should be #ifdef?

Are you happy for these things to be raised on Github, or should I use the forum?

rgds

K7MDL2 commented 2 years ago

You are correct, i had the ifndef for testing, must have missed setting it back to ifdef.

I will fix it tonight.

You can raise issues here, i read everything. Thanks for reporting that.

Sent from my T-Mobile 4G LTE Device Get Outlook for Androidhttps://aka.ms/ghei36

From: G3ZQC @.> Sent: Monday, May 9, 2022 2:56:52 PM To: K7MDL2/KEITHSDR @.> Cc: K7MDL @.>; Comment @.> Subject: Re: [K7MDL2/KEITHSDR] Compilation error with USE_RS_HFIQ not defined (Issue #8)

Still fails with me: Controls.cpp:501

ifndef USE_RS_HFIQ

// Compute the band index for the new target band an ensure it is in limits if (RS_HFIQ.find_new_band(old_VFOB, &curr_band)) // return the updated band index for the new freq

else

if (find_new_band(old_VFOB, &curr_band))

endif

Loos like #ifndef should be #ifdef?

Are you happy for these things to be raised on Github, or should I use the forum?

rgds

— Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FK7MDL2%2FKEITHSDR%2Fissues%2F8%23issuecomment-1121624365&data=05%7C01%7C%7C59892a4fc9ef4bcb4b0708da3206d3a3%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637877302143197701%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=6myyKUH96iPKav4viEvlMC2%2FIDnOa6%2F%2Fw4y5756TgT8%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAPLVE7GJ4TATHXQYVWG5QOLVJGC2JANCNFSM5VPK52BQ&data=05%7C01%7C%7C59892a4fc9ef4bcb4b0708da3206d3a3%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637877302143197701%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=It6ySlKjWBgWHgkfRZ%2B6aXnP05s88URav02TdJhKMkc%3D&reserved=0. You are receiving this because you commented.Message ID: @.***>