search

K8sbykeshed / k8s-service-validator

Kubernetes Network Service Validator
22 stars 10 forks source link

Fix kpng jobs on CI #47

Open knabben opened 3 years ago

knabben commented 3 years ago

Fix kpng jobs on CI Add golang-ci on CI

knabben commented 3 years ago

List of open issues 

  Running [/home/runner/golangci-lint-1.43.0-linux-amd64/golangci-lint run --out-format=github-actions --path-prefix=. --issues-exit-code=0] in [/home/runner/work/k8s-service-lb-validator/k8s-service-lb-validator] ...
  Error: Error return value is not checked (errcheck)
  Error: Error return value is not checked (errcheck)
  Error: Error return value is not checked (errcheck)
  Error: Error return value of `service.WaitForEndpoint` is not checked (errcheck)
  Error: Error return value of `services.Delete` is not checked (errcheck)
  Error: Error return value of `service.WaitForEndpoint` is not checked (errcheck)
  Error: Error return value of `services.Delete` is not checked (errcheck)
  Error: Error return value of `serviceTCP.WaitForEndpoint` is not checked (errcheck)
  Error: Error return value of `serviceUDP.WaitForEndpoint` is not checked (errcheck)
  Error: Error return value of `services.Delete` is not checked (errcheck)
  Error: Error return value of `service.WaitForEndpoint` is not checked (errcheck)
  Error: unnamedResult: consider giving a name to these results (gocritic)
  Error: unnamedResult: consider giving a name to these results (gocritic)
  Error: nestingReduce: invert if cond, replace body with `continue`, move old body after the statement (gocritic)
  Error: rangeValCopy: each iteration copies 720 bytes (consider pointers or indexing) (gocritic)
  Error: unnamedResult: consider giving a name to these results (gocritic)
  Error: appendCombine: can combine chain of 2 appends into one (gocritic)
  Error: File is not `gofmt`-ed with `-s` (gofmt)
  Error: File is not `gofumpt`-ed (gofumpt)
  Error: File is not `gofumpt`-ed (gofumpt)
  Error: File is not `gofumpt`-ed (gofumpt)
  Error: File is not `goimports`-ed (goimports)
  Error: don't use ALL_CAPS in Go names; use CamelCase (golint)
  Error: don't use ALL_CAPS in Go names; use CamelCase (golint)
  Error: Consider preallocating `externalIPs` (prealloc)
  Error: Consider preallocating `ports` (prealloc)
  Error: Consider preallocating `namespaces` (prealloc)
  Error: unnecessary trailing newline (whitespace)
  Error: S1000: should use for range instead of for { select {} } (gosimple)
  Error: S1021: should merge variable declaration with assignment on next line (gosimple)
  Error: S1021: should merge variable declaration with assignment on next line (gosimple)
  Error: S1021: should merge variable declaration with assignment on next line (gosimple)
  Error: unreachable: unreachable code (govet)
  Error: unreachable: unreachable code (govet)
  Error: unreachable: unreachable code (govet)