search

KABBOUCHI / nova-logs-tool

A Laravel Nova tool to manage and keep track of each one of your logs files.
MIT License
73 stars 17 forks source link

Ward routes are registered #24

Open tpetry opened 4 years ago

tpetry commented 4 years ago

You have clearly stated that KABBOUCHI/nova-logs-tool is built on KABBOUCHI/laravel-ward which is absolutely ok. But using the nova plugin should not publish routes to ward:

Domain Method URI Name Action Middleware
GET|HEAD ward/api/daily-log-files KABBOUCHI\Ward\Http\Controllers\Api\LogsController@dailyLogFiles web,KABBOUCHI\Ward\Http\Middleware\Authenticate
DELETE ward/api/logs KABBOUCHI\Ward\Http\Controllers\Api\LogsController@delete web,KABBOUCHI\Ward\Http\Middleware\Authenticate
GET|HEAD ward/api/logs KABBOUCHI\Ward\Http\Controllers\Api\LogsController@index web,KABBOUCHI\Ward\Http\Middleware\Authenticate
GET|HEAD ward/api/logs/{log} KABBOUCHI\Ward\Http\Controllers\Api\LogsController@show web,KABBOUCHI\Ward\Http\Middleware\Authenticate
GET|HEAD ward/{view?} ward.index KABBOUCHI\Ward\Http\Controllers\WardController@index web,KABBOUCHI\Ward\Http\Middleware\Authenticate
KABBOUCHI commented 4 years ago

plz add this LOG_VIEWER_ENABLE_ROUTES=false to .env file

tpetry commented 4 years ago

This removes the routes but not everyone is aware of this setting. The routes should not have been registered in the first place, my application failed an audit because of some unknown unexplainable routes registered.

KABBOUCHI commented 4 years ago

I'll add it to readme file

stepanenko3 commented 2 years ago

@tpetry

https://github.com/stepanenko3/nova-logs-tool/releases/tag/v1.1.1

This release remove ward routes I'll do a PR a little later