search

KABBOUCHI / vue-tippy

VueJS Tooltip powered by Tippy.js
https://vue-tippy.netlify.app
MIT License
726 stars 87 forks source link

<tippy :to> does not work #213

Closed martindzejky closed 2 years ago

martindzejky commented 2 years ago

In the Tipppy component, there's this:

https://github.com/KABBOUCHI/vue-tippy/blob/6a98ac4892ee42fd517c594078d23f71264e4bba/src/components/Tippy.ts#L76

which also deletes the option from the props, and therefore the following code never works. I cannot use the :to="element" option of the Tippy component. Is this a bug?

martindzejky commented 2 years ago

@KABBOUCHI do you accept PRs for this? It looks like a trivial fix which I could make if it helps.

ilse-langnar commented 2 years ago

@KABBOUCHI do you accept PRs for this? It looks like a trivial fix which I could make if it helps.

Can you show me the solution so I can implement it??

KABBOUCHI commented 2 years ago

we need to break the reference here https://github.com/KABBOUCHI/vue-tippy/blob/6a98ac4892ee42fd517c594078d23f71264e4bba/src/components/Tippy.ts#L72

and we also need to remove tag, contentTag and contentClass from options too

martindzejky commented 2 years ago

we need to break the reference here

https://github.com/KABBOUCHI/vue-tippy/blob/6a98ac4892ee42fd517c594078d23f71264e4bba/src/components/Tippy.ts#L72

Exactly, just do let options = {...props} as TippyOptions & ....

KABBOUCHI commented 2 years ago

fixed in 6.0.0-alpha.37