KAMI911 / osm_poi_matchmaker

OSM POI Matchmaker
GNU General Public License v3.0
9 stars 4 forks source link

synchronize with name-suggestion-index wikidata brands #15

Open ImreSamu opened 5 years ago

ImreSamu commented 5 years ago

the https://github.com/osmlab/name-suggestion-index project (used by iD editor) start adding wikidata brands

imho: We need to check and synchronize the branding metadata.

for example:

  "amenity/bank|Budapest Bank": {
    "count": 61,
    "tags": {
      "amenity": "bank",
      "brand": "Budapest Bank",
      "brand:wikidata": "Q27493463",
      "brand:wikipedia": "en:Budapest Bank",
      "name": "Budapest Bank"
    }

full metadata:

KAMI911 commented 5 years ago

It is a great idea @ImreSamu ! I can collect the currently applied tags for each type of POIs. Can you help to arrange the correct tags? Currently osm_poi_matchmaker use way more tags than name-suggestion-index. For example in case of Budapest Bank I combined the two data:

  "amenity/bank|Budapest Bank": {
    "count": 61,
    "tags": {
        "amenity": "bank",
        "brand": "Budapest Bank",
        "brand:wikidata": "Q27493463",
        "brand:wikipedia": "en:Budapest Bank",
        "operator": "Budapest Bank Zrt.",
        "bic": "BUDAHUHB"
        "atm": "yes",
        "addr:country": "HU",
        "air_conditioning": "yes"
    }

I hope you can help out this issue to have more tags in common. Thank you!

KAMI911 commented 4 years ago

If you want we are able to write a small program that reads the database and generate this form of name-suggestion-index file.

KAMI911 commented 4 years ago

@ImreSamu, Can we use more tags, or only use few already used?

ImreSamu commented 4 years ago

imho : let's discuss this on the osm hu mailing list.

this tags are country dependent tags .. so if open some branch in slovakia ; then this tags will be a mistake ..

        "addr:country": "HU",
        "operator": "Budapest Bank Zrt.",
        "bic": "BUDAHUHB"

and this is not guaranteed for the new bank offices.

        "atm": "yes",
        "air_conditioning": "yes"

and probably we need to add a

KAMI911 commented 3 years ago

I have collected the currently used tags here:

KAMI911 commented 3 years ago

imho : let's discuss this on the osm hu mailing list.

this tags are country dependent tags .. so if open some branch in slovakia ; then this tags will be a mistake ..

        "addr:country": "HU",
        "operator": "Budapest Bank Zrt.",
        "bic": "BUDAHUHB"

Yes, this is for Hungarian branch only.

and this is not guaranteed for the new bank offices.

        "atm": "yes",
        "air_conditioning": "yes"

I expect next bank will provide same user experience as all others.

and probably we need to add a

* `"countryCodes": ["hu"],`
  restriction.

So what is next @ImreSamu? I provided all information in wiki for syncing with name-suggestion-index.