KAMI911 / osm_poi_matchmaker

OSM POI Matchmaker
GNU General Public License v3.0
9 stars 4 forks source link

Address corrections of the source data #94

Open vasony opened 3 years ago

vasony commented 3 years ago

The following addresses differ from "Állandó postai szolgáltatóhelyek", and the street not exists in osm. https://www.posta.hu/static/internet/download/Allando_postai_szolgaltatohelyek.xlsx

CIB ATM

vasony commented 3 years ago

if you can create global patch table, we can manage these changes modifying the patch table instead of modifying the source code continuously. also fixes #93 eg:

orig_postcode;orig_city;orig_street;orig_no;new_postcode;new_city;new_street;new_number
3368;Boconád;Ságvári Endre utca;5;3368;Boconád;Kossuth Lajos út;12;
7346;Bikal;Zrinyi utca;*;7346;Bikal;Zrínyi Miklós utca;*;

you can use a special char (asterisk) to match for all numbers in the street (Bikal)

vasony commented 3 years ago

more address corrections can be found here: https://www.openstreetmap.org/changeset/102052652

KAMI911 commented 3 years ago

Current dataset from Magyar Posta: `

437309
<name>
 Boconád posta
</name>
<city>
 Boconád
</city>
<street>
 <name>
  Ságvári Endre
 </name>
 <type>
  utca
 </type>
 <housenumber>
  5
 </housenumber>
</street>

`

`

310404
<name>
 Sáp postapartner
</name>
<city>
 Sáp
</city>
<street>
 <name>
  Derkovits Gy
 </name>
 <type>
  utca
 </type>
 <housenumber>
  1
 </housenumber>
</street>

`

`

341301
<name>
 Jéke postapartner
</name>
<city>
 Jéke
</city>
<street>
 <name>
  Ifjusági
 </name>
 <type>
  út
 </type>
 <housenumber>
  3
 </housenumber>
</street>

`

vasony commented 3 years ago

This issue is not only related to posta, related to every data source. We can close the issue after implementing the extended patch, and inserting these examples into it.

KAMI911 commented 2 years ago

Avia:

KAMI911 commented 2 years ago

@vasony, could you add your changes to this file: https://github.com/KAMI911/osm_poi_matchmaker/blob/double_store/osm_poi_matchmaker/data/poi_patch.csv ?

Thank you!

vasony commented 2 years ago

Unfortunately I have not collected all the changes made on post offices. I suggest you to select a data source (eg. posta), create an update .osm file without committing it to osm, then I can review the diff to add the changes to the file mentioned here. After some loops, we can create the final version.