KAMKEEL / CustomNPC-Plus

Custom Version of 1.7.10 CustomNPC with backported features and original expansions
https://www.curseforge.com/minecraft/mc-mods/customnpc-plus
Other
53 stars 34 forks source link

Missing `customnpcs.refmap.json` #133

Open Veritaris opened 1 month ago

Veritaris commented 1 month ago

Missing customnpcs.refmap.json

Versions:

Hi. 1.9.3 release build does not contain mixins.customnpcs.refmap.json file that makes it impossible to run in production environment. Can you please rebuild it and re-upload or create a new release

[23:22:37] [Client thread/FATAL]: Mixin apply failed mixins.customnpcs.json:MixinModelBase -> net.minecraft.client.model.ModelBase: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException @Inject annotation on handler$setLivingAnimations$zzd000 could not find any targets matching 'setLivingAnimations' in the target class net.minecraft.client.model.ModelBase. No refMap loaded.
org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: @Inject annotation on handler$setLivingAnimations$zzd000 could not find any targets matching 'setLivingAnimations' in the target class net.minecraft.client.model.ModelBase. No refMap loaded.

1.9.3 on the left, 1.8.6 on the right side evidence

Veritaris commented 1 month ago

Local project build has this file изображение As a hotfix anyone who faced same issue can try to create file mixins.customnpcs.refmap.json inside jar and paste the following inside:

{
  "mappings": {
    "noppes/npcs/mixin/MixinEntityRenderer": {
      "renderWorld": "Lnet/minecraft/client/renderer/EntityRenderer;func_78471_a(FJ)V"
    },
    "noppes/npcs/mixin/MixinItemRenderer": {
      "renderItemInFirstPerson": "Lnet/minecraft/client/renderer/ItemRenderer;func_78440_a(F)V"
    },
    "noppes/npcs/mixin/MixinModelBase": {
      "setLivingAnimations": "Lnet/minecraft/client/model/ModelBase;func_78086_a(Lnet/minecraft/entity/EntityLivingBase;FFF)V"
    }
  },
  "data": {
    "searge": {
      "noppes/npcs/mixin/MixinEntityRenderer": {
        "renderWorld": "Lnet/minecraft/client/renderer/EntityRenderer;func_78471_a(FJ)V"
      },
      "noppes/npcs/mixin/MixinItemRenderer": {
        "renderItemInFirstPerson": "Lnet/minecraft/client/renderer/ItemRenderer;func_78440_a(F)V"
      },
      "noppes/npcs/mixin/MixinModelBase": {
        "setLivingAnimations": "Lnet/minecraft/client/model/ModelBase;func_78086_a(Lnet/minecraft/entity/EntityLivingBase;FFF)V"
      }
    }
  }
}
Pilzinsel64 commented 1 month ago

Hm, seems that doens't help on my side. Same problem. 🤔

Veritaris commented 4 weeks ago

@Pilzinsel64, hi! What errordo you have, same is my codeblock? Did you try to create mixins.customnpcs.refmap.json file with content I've added above?

Pilzinsel64 commented 3 weeks ago

@Veritaris Yes, but didn't work for whatever reason. Had a similar issue with an own Mod with own mixins based on the GTNH template in the past too. I told Kam about this issue on Discord and he answered:

That’s on the GitHub releases right? Yeah I’ll try and fix it none of them have built properly Just download from curseforge or Modrinth for now

I'm using CurseForge for now as I need a working directl link for my update script.

Veritaris commented 3 weeks ago

Hmm, I'll check this neardays