[bug] itemslots not using the id that's set

KAMKEEL / CustomNPC-Plus

Custom Version of 1.7.10 CustomNPC with backported features and original expansions

https://www.curseforge.com/minecraft/mc-mods/customnpc-plus

Other

53 stars 34 forks source link

[bug] itemslots not using the id that's set #91

Closed 20Whey closed 1 year ago

20Whey commented 1 year ago

Issue description: When an itemslot is created via: event.gui.addItemSlot(int id, int x, int y); the id is completely detached from the itemSlot events, so it has no real use currently. Versions:

Minecraft: 1.7.10
Forge: the sameold sameold
CustomNPC+: 1.8.3 https://media.discordapp.net/attachments/1003994806457999461/1110557599360884857/image.png?width=401&height=105

c0508383 commented 1 year ago

Fixed! The old functionality of event.slotId has simply stayed around. If you want to get the component's ID in the GUI, you get it through event.slot.getID() instead.

20Whey commented 1 year ago

Thank you for the fix!