KAMKEEL / CustomNPC-Plus

Custom Version of 1.7.10 CustomNPC with backported features and original expansions
https://www.curseforge.com/minecraft/mc-mods/customnpc-plus
Other
53 stars 34 forks source link

[bug] UI creation of itemslot and subequent updated UI causing crash when new itemslot is clicked #93

Closed 20Whey closed 1 year ago

20Whey commented 1 year ago

If crashed, link to crash report (use a site such as pastebin): paste.ee containing the player script required to reproduce. https://paste.ee/p/5ujXl Versions:

24.05 15:40:25 [Server] INFO java.lang.IndexOutOfBoundsException: Index: 74, Size: 37 24.05 15:40:25 [Server] INFO at java.util.ArrayList.rangeCheck(ArrayList.java:659) ~[?:1.8.0_362] 24.05 15:40:25 [Server] INFO at java.util.ArrayList.get(ArrayList.java:435) ~[?:1.8.0_362] 24.05 15:40:25 [Server] INFO at noppes.npcs.containers.ContainerCustomGui.func_75144_a(ContainerCustomGui.java:111) ~[ContainerCustomGui.class:?] 24.05 15:40:25 [Server] INFO at net.minecraft.network.NetHandlerPlayServer.func_147351_a(NetHandlerPlayServer.java:2086) ~[nh.class:?] 24.05 15:40:25 [Server] INFO at net.minecraft.network.play.client.C0EPacketClickWindow.func_148833_a(SourceFile:32) ~[ix.class:?] 24.05 15:40:25 [Server] INFO at net.minecraft.network.play.client.C0EPacketClickWindow.func_148833_a(SourceFile:10) ~[ix.class:?] 24.05 15:40:25 [Server] INFO at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:245) ~[ej.class:?] 24.05 15:40:25 [Server] INFO at net.minecraft.network.NetworkSystem.func_151269_c(NetworkSystem.java:181) [nc.class:?] 24.05 15:40:25 [Server] INFO at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:1023) [MinecraftServer.class:?] 24.05 15:40:25 [Server] INFO at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:431) [lt.class:?] 24.05 15:40:25 [Server] INFO at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:842) [MinecraftServer.class:?] 24.05 15:40:25 [Server] INFO at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:692) [MinecraftServer.class:?] 24.05 15:40:25 [Server] INFO at java.lang.Thread.run(Thread.java:750) [?:1.8.0_362]

c0508383 commented 1 year ago

All fixed, thanks for the report!

20Whey commented 1 year ago

Thank you for the fix!