search

KAMKEEL / CustomNPC-Plus

Custom Version of 1.7.10 CustomNPC with backported features and original expansions
https://www.curseforge.com/minecraft/mc-mods/customnpc-plus
Other
53 stars 34 forks source link

Itemslots created via script don't have an id - also a visual itemslot /*duplication*/ bug when creating new itemslots #97

Closed 20Whey closed 8 months ago

20Whey commented 1 year ago

Issue description: creating itemslots via script seems to duplicate them, duplicated itemslots and normal itemslots created via script aren't acessible via id. can be produced in single player and multiplayer.

Versions:

Can it be reproduced with just CustomNPC+? If not, list the other mods required to reproduce the issue. I'm fairly certain this is just cnpc+ https://github.com/KAMKEEL/CustomNPC-Plus/assets/31368984/d2f74da4-20bf-4acd-b131-1a46c8100dd3

https://github.com/KAMKEEL/CustomNPC-Plus/assets/31368984/3f82e052-332d-4423-9c33-6e0bae963f97 as shown in this video, they are still the correct amount of slots? so I'm confused by the way the ui updates

20Whey commented 1 year ago

discovered the issue is gui.update(event.player);

https://github.com/KAMKEEL/CustomNPC-Plus/assets/31368984/1e459c41-c029-4ce7-b6d4-f38221dd15ce

20Whey commented 1 year ago

it's a visual bug, not straight duplication

KAMKEEL commented 8 months ago

Fixed! Will be released in 1.9!