search

KAfable / FTB-Interactions

4 stars 0 forks source link

Particle Effect related Memory Leak #759

Closed Torrenal closed 4 years ago

Torrenal commented 5 years ago

Not sure what triggered it, ParticleRain has 5 million instances in memory consuming 878MB of ram, ParticleSuspend has 1.2 million instances for another 202MB, ParticleSmokeLarge, ParticleFlame, ParticleSmokeNormal, ParticlePortal all also fit in there . . . I've even got 'ParticleSerpentBubble' for 11MB, despite not having been in the overworld for a while...

What I have is a heap dump with some additional details (Telemetries, some CPU metrics, some lock state, etc...)

image image image UsingAllTheRams.log

Willing to work with you to fix this, but I'm not sure what triggered the leak. If I had to guess - - whatever manages the particle effects may have died, or otherwise stopped work that includes clearing the list of particles, and in dying/failing, it doesn't replace the queue with a dummy queue that discards particle requests as they arrive - That would allow particle effects to break, without running Minecraft out of memory in the process (and yes, I am that paranoid in my own programming).

KAfable commented 5 years ago

Just a heads up this tracker is no longer in use.