KAfable / Interaction

Modpack for 1.12.2
6 stars 2 forks source link

[0.095] Water extractor not giving 50mB per use #37

Closed Hjaldar closed 6 years ago

Hjaldar commented 6 years ago

I see you are aware of this. https://github.com/Bartz24/SkyResources/issues/119 No response from the dev yet.

SkyResources.zs lines 191 and 192 attempt to change the water extractor to give 50mB per use. This doesn't work because the original recipe is not removed and takes precedence over the added recipe which gives 50mB.

Changing the removeRecipe to use ore:treeLeaves did not fix this issue (zenscript error). Iterating through everything in ore:treeLeaves and removing them individually also did not work.

The relevant line of code that adds the unremoveable recipe is here. It uses the treeLeaves oredict entry. I think the recipe isn't being removed because removeRecipe only takes an IItemStack as input. This looks unresolveable without dev input.

KAfable commented 6 years ago

Closing this issue to probably revisit at a later time, only really Bartz can fix this.