KBNLresearch / iromlab

Loader software for automated imaging of optical media with Nimbie disc robot
Apache License 2.0
31 stars 5 forks source link

Packaging: package as GUI app instead of console app #29

Closed bitsgalore closed 7 years ago

bitsgalore commented 7 years ago

Tried this in setup.py:

https://github.com/KBNLresearch/iromlab/commit/c2ab187fa2ed2513e5bdef0b0cce5933b899b932#diff-2eeaed663bd0d25b7e608891384b7298

But this has the unwanted side-effect that for each subprocess that is started using sub.Popen a console window pops up.

Might need to change Popen calls, see here:

http://stackoverflow.com/questions/1813872/running-a-process-in-pythonw-with-popen-without-a-console

Update to the above: adding shell=True to Popen call seems to do the trick:

p = sub.Popen(args,stdout=sub.PIPE,stderr=sub.PIPE, shell=True)
bitsgalore commented 7 years ago

Popen problem fixed by: https://github.com/KBNLresearch/iromlab/commit/5805416398b93ef0fdd07377ebc1a0339c020dee

BUT:

bitsgalore commented 7 years ago
bitsgalore commented 7 years ago

All FIXED, Desktop shortcut now created as post-install: https://github.com/KBNLresearch/iromlab/commit/3e798e74aa18d860432c164c905513194a2d7298