KBNLresearch / iromlab

Loader software for automated imaging of optical media with Nimbie disc robot
Apache License 2.0
31 stars 5 forks source link

Query for Title sometimes doesn't return main title #51

Closed bitsgalore closed 7 years ago

bitsgalore commented 7 years ago

Examples:

http://jsru.kb.nl/sru/sru?x-collection=GGC&operation=searchRetrieve&startRecord=1&maximumRecords=1&recordSchema=dcx&query=26732653X

Here Iromlab returns:

<dc:title xml:lang="nl" xsi:type="dcx:intermediatetitle">3 vwo</dc:title>

But instead it should return this:

<dc:title xml:lang="nl" xsi:type="dcx:maintitle">D'accord!. Frans voor de onderbouw. Docentenaudio</dc:title>

Other example:

http://jsru.kb.nl/sru/sru?x-collection=GGC&operation=searchRetrieve&startRecord=1&maximumRecords=1&recordSchema=dcx&query=185299814

Iromlab returns:

<dc:title xml:lang="nl" xsi:type="dcx:intermediatetitle">2 vbo mavo</dc:title>

But should return this instead:

<dc:title xml:lang="nl" xsi:type="dcx:maintitle">Stemming : muziek voor de basisvorming. CD's</dc:title>

So search for Title may need additional check to ensure xsi:type=dcx:maintitle.

This will go wrong in omSipCreator as well.

bitsgalore commented 7 years ago

Some more info on this: even though it is easy to query specifically for maintitle records by adding a @property definition in sru.py , this doesn't solve the problem because the type attribute isn't always used. Example:

<dc:title xml:lang="nl">Thea Beckman</dc:title>

So it seems maintitle / intermediatetitle are used sometimes, but not always and not in a consistent or predictable way.

bitsgalore commented 7 years ago

Fixed, now display main title if it exists, otherwise use title w/o attribute: https://github.com/KBNLresearch/iromlab/commit/92fdbf3f44970ca597e7a99df1ece12a80530b0b